Giter Site home page Giter Site logo

Comments (2)

danielhuppmann avatar danielhuppmann commented on July 22, 2024

cc @phackstock

from nomenclature.

phackstock avatar phackstock commented on July 22, 2024

Thanks @danielhuppmann for opening the issue.
My first thought is concerning the case in which the mapping changes between the upload and the download, i.e. potential renaming. Since the model mappings are versioned we could "rewind the clock" and use the one as it was in place when the data was uploaded. Although just because it is technically possible, does not automatically make it a good idea. It might be confusing if the output is different than the current model mapping.

Regarding the open question my preferences would be as follows:

  • For doing a "reverse" model mapping (not a complete renaming upon export, which might be another interesting feature), I would keep all the common regions as is and rename the model native ones.
  • Implementation my first instinct would be to go with a separate ReverseRegionProcessor as you suggested. The easiest way to avoid lots of code duplication would probably be to inherit from the RegionProcessor and simply overwrite the apply() function.

from nomenclature.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.