Comments (1)
I feel your pain on the verbosity point - it's something I encountered too (although I wasn't using Angular). I'm concerned that the extra event
properties might make the code less readable, especially when there are multiple handlers/events.
I like the idea of some way of binding handlers that automatically unbinds when hiding the anno though. Perhaps the default behaviour of onHide
should be to try some unbind
method of the returned object(s) - almost like an event dispatcher.
We could then write some shorthand to construct the appropriate undoable handler object:
target: "#attribute-common-class"
content: "Click the <code>tag token</code> below to continue"
buttons: []
onShow: (anno, $target, $annoElem) ->
return new AnnoHandler(".tags_token", "mouseup", ->
setTimeout (-> anno.switchToChainNext()), 10
)
#onHide would automatically call the annoHandler.unbind()
This could foreseeably work with multiple handlers:
target: "#attribute-common-class"
content: "Click the <code>tag token</code> below to continue"
buttons: []
onShow: (anno, $target, $annoElem) ->
[new AnnoHandler(".tags_token", "mouseup", ->
setTimeout (-> anno.switchToChainNext()), 10
), new AnnoHandler(".something_else", "click", ->
setTimeout (-> anno.switchTo(someOtherTour)), 10 #slightly contrived
)]
#onHide would automatically call annoHandler.unbind() for each in the list.
from anno.js.
Related Issues (20)
- example file references don't exist HOT 1
- Does not scroll to correct position in vertically scrollable div
- Submit to npm / bower registries
- NextButton cause jquery validation fired HOT 2
- Multipage tour
- Unable to set parent element of overlay
- Conditional tour steps
- Data-driven Annotations
- event.preventDefault() required on default tour button clicks? HOT 2
- Event for tour dismissed
- Static Backdrop HOT 1
- Invalid jQuery require HOT 1
- clicking outside doesn't close annojs
- Serious BUG: Clicking fast on next causes anno.js to malfunction
- IE 10 vs IE 11
- Fix: button type should set to button
- Unable to place border on .anno anno-arrow
- Form submits on NextButton click HOT 2
- it doesn't support vanilla JavaScript
- Anno.js does not work on nested tables
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from anno.js.