Giter Site home page Giter Site logo

Comments (1)

iamdanfox avatar iamdanfox commented on July 28, 2024

I feel your pain on the verbosity point - it's something I encountered too (although I wasn't using Angular). I'm concerned that the extra event properties might make the code less readable, especially when there are multiple handlers/events.

I like the idea of some way of binding handlers that automatically unbinds when hiding the anno though. Perhaps the default behaviour of onHide should be to try some unbind method of the returned object(s) - almost like an event dispatcher.

We could then write some shorthand to construct the appropriate undoable handler object:

    target: "#attribute-common-class"
    content: "Click the <code>tag token</code> below to continue"
    buttons: []
    onShow: (anno, $target, $annoElem) ->
        return new AnnoHandler(".tags_token", "mouseup", -> 
            setTimeout (-> anno.switchToChainNext()), 10
        )
    #onHide would automatically call the annoHandler.unbind()

This could foreseeably work with multiple handlers:

    target: "#attribute-common-class"
    content: "Click the <code>tag token</code> below to continue"
    buttons: []
    onShow: (anno, $target, $annoElem) ->
        [new AnnoHandler(".tags_token", "mouseup", -> 
            setTimeout (-> anno.switchToChainNext()), 10
        ), new AnnoHandler(".something_else", "click", ->
            setTimeout (-> anno.switchTo(someOtherTour)), 10  #slightly contrived
        )]
    #onHide would automatically call annoHandler.unbind() for each in the list.

from anno.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.