Giter Site home page Giter Site logo

Comments (8)

Chaphasilor avatar Chaphasilor commented on May 10, 2024

I think using the default source should work for now.
But that reload should be easy to prevent :D

from decentralized-video-chat.

ianramzy avatar ianramzy commented on May 10, 2024

I added the refresh because if you are using headphones as the default audio input, and then you unplug your headphone you lose microphone input. This was a quick fix, there is definitely a more elegant way to do this

from decentralized-video-chat.

Chaphasilor avatar Chaphasilor commented on May 10, 2024

We should probably check if there are any inout devices at all and if not, toggle the 'mute' button to reflect that, along with an error message if the user tries to unmute themselves.

from decentralized-video-chat.

vinyll avatar vinyll commented on May 10, 2024

We experimented some issues where the page would refresh by itself.
I can't tell for sure if the headphones where disconnecting accidentally of what there reseaons were.
However it happens systematically on one side (MacOS latest stable FF) when trying to share screen.

from decentralized-video-chat.

Chaphasilor avatar Chaphasilor commented on May 10, 2024

So I've just looked at this, but I really think fixing this causes more problems than it solves :/
For example, we would need to add and remove tracks, detect what track are available, add new error handlers and status text, etc.

I'd recommend just keeping it the way it is with the reloads, but adding the ability to join a room even if no video input is available and setting some state (video disabled, audio muted, etc.) in localstorage to solve #13

from decentralized-video-chat.

vinyll avatar vinyll commented on May 10, 2024

If that's the conclusion, I guess a message to the user would be helpful. Ex: "Microphone was unplugged. Reloading…".

from decentralized-video-chat.

Chaphasilor avatar Chaphasilor commented on May 10, 2024

Yeah this shouldn't be a problem :)

from decentralized-video-chat.

ianramzy avatar ianramzy commented on May 10, 2024

I would really like to see auto swapping of input and output. Checkout my branch audio-sucks to see some of what I did for detecting and switching to new tracks

from decentralized-video-chat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.