Prereq checker tool for WAIOps 3.5 "uprates" errors (info as warning and warning as errors)

[nastacio]

Prereq checker tool for WAIOps 3.5 "uprates" errors (info as warning and warning as errors)

[kvijai82]

Liam, could you please review these and update appropriately? Thanks!

[lsalazar1]

Hi, these should be included in the PR for the pre-req script 3.6.1 updates!

[lsalazar1]

@nastacio Please see the changes here, and verify if this issue has been remediated. Thanks!

[nastacio]

@nastacio Please see the changes here, and verify if this issue has been remediated. Thanks!

Should I read into this that the issue will not be addressed in version 3.5.x of the script?

[nastacio]

A cursory check on the 3.6 script (ran it against a cluster without any storage or prereq in place) still shows a a few of the original problems:

nastacio@Yeager4 3.6 % ./prereq.sh                                                                                                          
Using project "default" on server "https://api.dncp4d.cp.fyre.ibm.com:6443".

Starting IBM Cloud Pak for Watson AIOps AI Manager prerequisite checker v3.6... 


[INFO] =================================Openshift Container Platform Version Check=================================
[INFO] Checking OCP Version. Compatible Versions of OCP are v4.8 and v4.10.
[INFO] OCP Version 4.10.46 is compatible with IBM Cloud Pak for Watson AIOps AI Manager

[INFO] =================================Entitlement Pull Secret=================================
[INFO] Checking whether the Entitlement secret or Global pull secret is configured correctly.
[INFO] Checking if the job 'cp4waiops-entitlement-key-test-job' already exists.
[INFO] The job with name 'cp4waiops-entitlement-key-test-job' was not found, so moving ahead and creating it.
[INFO] Creating the job 'cp4waiops-entitlement-key-test-job' 
job.batch/cp4waiops-entitlement-key-test-job created
[INFO] Verifying if the job 'cp4waiops-entitlement-key-test-job' completed successfully..
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
usage: sleep seconds
[INFO] SUCCESS! Entitlement secret is configured correctly.
job.batch "cp4waiops-entitlement-key-test-job" deleted
[INFO] =================================Entitlement Pull Secret=================================

[INFO] =================================Storage Provider=================================
[INFO] Checking storage providers

[WARNING] No StorageClusters found with "Online" status found. In order for Portworx to work, an instance of StorageCluster must have a status of "Online". Skipping configuration check for Portworx.
No resources found in openshift-storage namespace.

[INFO] Openshift Data Foundation not running.
[INFO] No IBM Cloud Storage not found... Skipping configuration check for IBM Cloud Storage Check.
[INFO] No IBM Spectrum Fusion or IBM Spectrum Scale Container Native... Skipping configuration check for IBM Spectrum.
  At least one of the four Storage Providers are required
  The supported Storage Providers are Portworx, Openshift Data Foundation, IBM Cloud Storage for ROKS, or IBM Spectrum Fusion/IBM Spectrum Scale Container Native. See https://ibm.biz/storage_consideration_360 for details.
[INFO] =================================Storage Provider=================================

[INFO] =================================Network Policy=================================
[INFO] Checking Network Policy configuration
  Namespace default DOES NOT have the expected metadata label 
Please see https://ibm.biz/aiops_netpolicy_36 to configure a network policy
[INFO] =================================Network Policy=================================

[INFO] =================================Small or Large Profile Install Resources=================================
[INFO] Checking for cluster resources

[INFO] ==================================Resource Summary=====================================================
[INFO]                                       Nodes   |      vCPU      |     Memory(GB)
[INFO] Small profile(available/required)  [  3 / 3 ]   [  62 / 56 ]       [  209 / 140 ]
[INFO] Large profile(available/required)  [  3 / 10 ]   [  62 / 156 ]       [  209 / 360 ]
[INFO] ==================================Resource Summary=====================================================
[INFO] Cluster currently has resources available to create a small profile of Cloud Pak for Watson AIOps AI Manager

[INFO] =================================Small or Large Profile Install Resources=================================


[INFO] =================================Prerequisite Checker Tool Summary=================================
      [  PASS  ] Openshift Container Platform Version Check 
      [  PASS  ] Entitlement Pull Secret
      [  FAIL  ] Storage Provider
      [  FAIL  ] Network Policy
      [  PASS  ] Small or Large Profile Install Resources
[INFO] =================================Prerequisite Checker Tool Summary=================================

1. (minor) Those extraneous usage: sleep seconds messages in the output are probably due to the usage of SLEEP_LOOP=5s inside the code. I ran the script on a macOS terminal and that s at the end is non standard on macOS or Unix BSD. Removing the s at the end will address the issue and not affect the results (sleep 5 should work across all Unix variants.)

2. (medium) There are two failures identified (Storage Provider and Network Policy), yet the CLI now classifies the surrounding output flagging those errors as INFO. The lack of a supported storage provider should at least be a warning. If prerequisite network configuration is a mandatory prerequisite, the message around it should be an error.

3. (major) There is still a warning about a problem with Portworx, even though this cluster has no Portworx storage.

4. (medium) The shortened link https://ibm.biz/aiops_netpolicy_36 leads to ibm.com (The shortlink https://ibm.biz/storage_consideration_360 is fine)

5. (major) Even with the two failures, the CLI is reporting a successful exit code of 0. This is particularly troublesome for integrators attempting to incorporate the CLI into automated processes:

   nastacio@Yeager4 3.6 % echo $?
   0

[nastacio]

I ran the script against a cluster running ODF:

[INFO] =================================Storage Provider=================================
[INFO] Checking storage providers

[WARNING] No StorageClusters found with "Online" status found. In order for Portworx to work, an instance of StorageCluster must have a status of "Online". Skipping configuration check for Portworx.
[INFO] Openshift Data Foundation found. Skipping configuration check for ODF.
[INFO] No IBM Cloud Storage not found... Skipping configuration check for IBM Cloud Storage Check.
[INFO] No IBM Spectrum Fusion or IBM Spectrum Scale Container Native... Skipping configuration check for IBM Spectrum.

Checking Openshift Data Foundation Configuration...
Verifying if Red Hat Openshift Data Foundation pods are in "Running" or "Completed" status
[INFO] Pods in openshift-storage project are "Running" or "Completed"
[INFO] ocs-storagecluster-ceph-rbd exists.
[INFO] ocs-storagecluster-cephfs exists.
[INFO] openshift-storage.noobaa.io exists.
[INFO] No warnings or failures found when checking for Storage Providers.
[INFO] =================================Storage Provider=================================

1. It says No warnings or failures found when checking for Storage Providers. even though it prints a warning. The warning is a false positive, but that indicates the logic behind the assessment of "No warnings ... found" needs to be revisited.
2. [No IBM Cloud Storage not found.] -> There is an extraneous "not" in that sentence.
3. [Openshift Data Foundation found. Skipping configuration check for ODF.] -> That is not correct, the check is not skipped