Numberinput requires mouse hover for keyboard input

[the-marenga]

Numberinput requires mouse hover for keyboard input

[the-marenga]

Looking at the source, this seems to be because:

iced_aw/src/widgets/number_input.rs

Lines 409 to 411 in bb7540f

	if layout
	.bounds()
	.contains(cursor.position().unwrap_or_default())

is not met, which ignores all inputs.

My question then becomes, why would this check be necessary for keyboard inputs?
Mouse stuff might be a different story, but keyboard events check, if the input is focused themself anyways.

iced_aw/src/widgets/number_input.rs

Lines 442 to 445 in bb7540f

	if child
	.state
	.downcast_mut::<text_input::State<Renderer::Paragraph>>()
	.is_focused() =>

Changing the initial check to:

        if layout
            .bounds()
            .contains(cursor.position().unwrap_or_default()) 
             || matches!(event, Event::Keyboard(keyboard::Event::KeyPressed { .. }))

Makes the widget behave as I would expect

[genusistimelord]

make sure to try that with multiple number inputs and see if they all input when the keyboard is pressed. Also yeah ill need to check to see what iced currently is doing for textboxes as this was a widget made back before many of the major changes occurred.

[the-marenga]

Just tested this with multiple number_inputs with this fix and they all behave as expected. Completely independent. They behave exactly like multiple text_inputs on switching/losing focus, whilst inputing text.

The only thing to note is that this now allows scrolling one element, whilst inputing text into another, but I am pretty sure this is how it would be expected to behave.

This quick fix does however call self.content.on_event for each unfocused number_input, whenever a key is pressed, instead of returning event::Status::Ignored, which might introduce something I am not aware of rn, or lead to slower perf.
In addition the keyboard input does not work, when the mouse is over the inc/dec buttons, as that logic supercedes the keyboard input checks.

If you want, I can make a PR, that fixes this in a more sophisticated way

[genusistimelord]

please feel free too. yeah we did not want to cause weird bugs if you used the buttons over the keyboard input.