Comments (2)
Bug is some how related to executing scripts in a client from the main process, it seems other client's lose webcontents and end up breaking, not sure why they are being destroyed, could be because of the async and it continues to run the close in the background instead of waiting for the await to finish not sure if i can fix it or find a work around yet, it may be due to browserviews being replaced with new webcontentviews, i may re-code the tab system to use them and see if that fixes the issue
from jimud.
I have a possible fix, after messing with electron fiddle and creating a basic test case i have been able to create a super slim test that breaks the close, i copied it and modified it using the new webContentView that replaces browserView and it worked correctly, so it seems i need to recode the entire mdi system to shift from browserView to webConttentView, see #248 as i already had a issue to work on that. electron 30 just moves it up, when i convert i will close that one and this issue
from jimud.
Related Issues (20)
- Display: Add column select mode
- Code editor: Add waterdrink room option HOT 3
- Electron 29 HOT 2
- Resize/minimize on KDE 6 HOT 3
- White flashing on resizing in linux
- Skip more prompt delay HOT 1
- Hiding on linux lose window location when restored from maximize HOT 4
- Add filter/search to advanced preferences view
- Code editor: Spellchecker en-US does not work on windows
- Add confirm on close for editors HOT 2
- Wayland support HOT 3
- Command input: Allow a fixed set height HOT 1
- Status: Add ability to set the monster/party icons HOT 1
- Code editor: Tab drop down menu not updated HOT 1
- Code editor: project/workspace system HOT 1
- Code editor: Sessions
- Display: add highlight support to scroll bar
- Mapper: copy marked path HOT 2
- Mapper: 3d a* pathing or some other one HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jimud.