Giter Site home page Giter Site logo

Comments (7)

hknahal avatar hknahal commented on August 12, 2024

Will release this change in Dictionary 1.17 since it requires a validation rule in clinical to make this a required field if the specimen is tumour: icgc-argo/argo-clinical#872

from argo-dictionary.

edsu7 avatar edsu7 commented on August 12, 2024

Dan is working on clinical implementation.

from argo-dictionary.

puneet-oicr avatar puneet-oicr commented on August 12, 2024

Testing possible once PR is approved on this

from argo-dictionary.

hknahal avatar hknahal commented on August 12, 2024

Tested in QA using dictionary version 124.1. All tests passed/failed as expected.

Test cases:

percent_tumour_cells_measurement_method submitted when specimen is Normal. Validation should fail
--> Validation failed as expected

percent_tumour_cells_measurement_method submitted when specimen is Tumour. Validation should pass
--> Validation passed as expected

percent_tumour_cells_measurement_method missing when specimen is Tumour. Validation should fail
--> Validation failed as expected

percent_tumour_cells_measurement_method missing when specimen is Normal. Validation should pass.
--> Validation passed as expected

from argo-dictionary.

puneet-oicr avatar puneet-oicr commented on August 12, 2024

tested and ready

from argo-dictionary.

puneet-oicr avatar puneet-oicr commented on August 12, 2024

Almost ready

from argo-dictionary.

hknahal avatar hknahal commented on August 12, 2024

Tested in Staging using Dictionary 1.17 and works as expected.

  • If percent_tumour_cells_measurement_method field is missing for a tumour specimen, an error is reported as expected:
    missing_percent_tumour_cells_measurement_method

If percent_tumour_cells_measurement_method field is submitted for a normal specimen, an error is reported as expected:
percent_tumour_cells_measurement_method_for_normal

Validates if percent_tumour_cells_measurement_method field is submitted for a tumour specimen.

from argo-dictionary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.