[UI]: Application Section A: Applicant Information Form & Validation

[icgc-argo]

[UI]: Application Section A: Applicant Information Form & Validation

[justincorrigible]

Figured that was the case and worked under that assumption, but it's good to double check :) thank you, @kcullion!

[kcullion]

thanks @caravinci . Small request for field label and note change.

Please change "Institution/Company Website" label to Researcher Profile URL
And the blue note will be Please provide a link to your profile on your institution/company website.
This field is still not required.
Zeplin mockup: https://zpl.io/bz3mDAX

[justincorrigible]

Excellent timing. Changes will be in by the time this gets to QA.
@blabadi I'm leaving the field name the same, unless you want to change it

[kcullion]

@caravinci they want to make "Researcher Profile URL" required. sorry for the last minute change

[justincorrigible]

This ticket required the following scope extensions (from the one initially established):

To enable local validation

• Enable passing custom blur and focus handlers into the UiKit Input (as well as an obvious focus shadow style, like the one in the Button and FormCheckbox components to ensure consistency throughout the library), allowing to visually discern pristine vs touched vs valid/invalid statuses, etc.
• Similar additional functionality for the Select component, to ensure consistency. This component also presented some odd behaviour in which it remained focused even after the user had clicked away from it (as noticed at platform. See image below for reference.)

[justincorrigible]

For VIII. Website, is it required or not? the Zeplin shows it as a Schrödinger:

[kcullion]

@caravinci ooops I see that I put the required for website in one mock but not the other. This is required on the current application, so I think it's meant to be required

[justincorrigible]

This ticket relies on some changes made to the Select and Multiselect components.
The change was necessary because a user without a mouse would break the validation and didn't want that edge case to block testing + approval. Furthermore, the Select would remain focused (halo shown) if a user opens it and then clicks away without choosing one of the options, which can be confusing.

Known issue: Wasn't able to cover all edge cases for the Multi select, though I did fix a few basic ones.
Will for sure have to continue working on it later. Moving on to other more urgent tasks.

[justincorrigible]

no problem at all! I'll add that requirement to the PR.

[rosibaj]

• Google email validaiton is wrong; should just validation regular email format.
• Postal code validation is wrong; should not include comma
• There is a build issue with styles; This should be resolved so the styling is translated correctly on build.

[justincorrigible]

Fixes for Google email and city, provice/state validation: #88
Working on a fix for the label styling

[kcullion]

@caravinci some more feedback:
(FYI, just made this ticket to be worked on when there's time: #93)

• For country - I shouldn't be able to add a new value in, I should have to select from the options that are listed. Like I was able to do this:
  

• also when I got that error in the screenshot above, then went to the next field to fill it out - the error didn't persist for country like it did for the other required fields

• For country, when I do select a value from the list of options, I can still type after that option
  

• The styles look different for that country field - different font sizes and no left padding. The field itself looks taller than the others as well
  

• Please apply these fixes to section B too: #18

I will review again when the build issue with styles is fixed on QA

[justincorrigible]

Yeah! I was hoping someone would notice those issues too... that's current default behaviour at the Multiselect component, and I think you can see it in platform-ui at prod.

I'd absolutely loooove to fix that, but didn't with this PR trying to keep the scope tight.
Looking forward to #93!!

[kcullion]

@caravinci @rosibaj I moved the feedback about the country field to this ticket: #93