Giter Site home page Giter Site logo

Comments (7)

rosibaj avatar rosibaj commented on August 12, 2024 1

hmm @kcullion I retested:

  • windows/chrome has the click issue i described
  • windows/firefox does NOT have the issue i described above
  • it sounds you in mac/chrome do NOT have the issue described above.

from dac-ui.

kcullion avatar kcullion commented on August 12, 2024 1

@rosibaj interesting. Removing the links for now solves this :)

from dac-ui.

rosibaj avatar rosibaj commented on August 12, 2024 1

lgtm thank you @caravinci

from dac-ui.

rosibaj avatar rosibaj commented on August 12, 2024

Tested June 17, 2021, 5:02:
we seem to have a click conflict - if i click the link inside the checkbox text, it does two things

  • opens the link
  • selects/deselects the checkbox. @kcullion as the link to the appendix is directly above, do we really need to repeat the link in the checkbox text?

from dac-ui.

kcullion avatar kcullion commented on August 12, 2024

@rosibaj when I click the link, it doesn't select the checkbox - it just opens the link.

I think in this case, we can remove those links from the checkbox, but do we want to handle the case where there may be a link in the checkbox? Actually let's cross that bridge when we get new content.

for now @caravinci please

  • remove the links to the appendices from the checkboxes

from dac-ui.

justincorrigible avatar justincorrigible commented on August 12, 2024

The reason you're experiencing different results when testing that issue is related to the outdated version of React used in Uikit... React@16. Their event bubbling was improved sometime last year with React@17, so we won't have an easy fix until the package is updated.

Removing the links for now. 👍

from dac-ui.

justincorrigible avatar justincorrigible commented on August 12, 2024

Indeed, changes made.
Pending further feedback from any other sections to open a PR.

image

from dac-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.