Comments (7)
hmm @kcullion I retested:
- windows/chrome has the click issue i described
- windows/firefox does NOT have the issue i described above
- it sounds you in mac/chrome do NOT have the issue described above.
from dac-ui.
@rosibaj interesting. Removing the links for now solves this :)
from dac-ui.
lgtm thank you @caravinci
from dac-ui.
Tested June 17, 2021, 5:02:
we seem to have a click conflict - if i click the link inside the checkbox text, it does two things
- opens the link
- selects/deselects the checkbox. @kcullion as the link to the appendix is directly above, do we really need to repeat the link in the checkbox text?
from dac-ui.
@rosibaj when I click the link, it doesn't select the checkbox - it just opens the link.
I think in this case, we can remove those links from the checkbox, but do we want to handle the case where there may be a link in the checkbox? Actually let's cross that bridge when we get new content.
for now @caravinci please
- remove the links to the appendices from the checkboxes
from dac-ui.
The reason you're experiencing different results when testing that issue is related to the outdated version of React used in Uikit... React@16. Their event bubbling was improved sometime last year with React@17, so we won't have an easy fix until the package is updated.
Removing the links for now. 👍
from dac-ui.
Indeed, changes made.
Pending further feedback from any other sections to open a PR.
from dac-ui.
Related Issues (20)
- Fix Text for When Admins Close Applications HOT 2
- Change Text for "System" to "DACO System" in Application History HOT 1
- Add Notification Banner for Mobile Access HOT 1
- Force User to Enter Special Code or Relevant Text Before Closing an Application HOT 2
- Renewal flow display - Remaining small fixes to integrate with attestation flow HOT 1
- Update Copyright Notice in Codebase HOT 1
- Dependency Updates HOT 1
- Add Ability to Review & Approve New Collaborators on Approved Apps HOT 1
- Add Ability to Indicate a Google Email as GSuite Address HOT 1
- Upgrade DAC-UI to Latest UI Kit
- Dashboard card - alignment for attestation + renew buttons HOT 1
- PAUSED and EXPIRED applications should download the full app package HOT 3
- Renewal app in renewal period displays incorrect banner HOT 1
- Disable Collaborator actions in EXPIRED state HOT 1
- Admins should not see Renew button HOT 1
- Dates in May Incorrectly Add a Period Character (".") to the Month HOT 4
- Add Confirmation Prompt Before Creating Renewal Application
- [Admin View] Banner with Link to Source App Should Display in All States
- Renewal ID Banner (Blue) Should Still Show Along with Attestation Banner HOT 1
- Prevent Existing Collaborator from Being Added Second Time
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dac-ui.