Giter Site home page Giter Site logo

Comments (7)

waruyama avatar waruyama commented on May 18, 2024

Thanks for the feedback. Is there any chance you can provide that SVG? Or maybe a simplified version that shows the same effect?

from svg-inject.

ricardobr001 avatar ricardobr001 commented on May 18, 2024

The image is inside this repo, name of the file is image.svg

from svg-inject.

waruyama avatar waruyama commented on May 18, 2024

This seems to be a problem with ID uniquification. If you turn off ID uniquification, the SVG should display as expected. Here is what you need to put into the <head> element:

<head>
  <script src="svg-inject.js"></script>
  <script>
    SVGInject.setOptions({
      makeIdsUnique: false // do not make ids used within the SVG unique      
    });
  </script>
</head>

I do not understand why it does not work in other browsers, but in any case this appears to be a bug in the library. I will have to take a really close look at this rather complex SVG.

from svg-inject.

waruyama avatar waruyama commented on May 18, 2024

The reason for this issue is that currently IDs referenced by attributes in the svg root element are not handled correctly. The provided SVG file has a filter set in the svg tag like this:

<svg xmlns="http://www.w3.org/2000/svg" style="background-color: rgb(255, 255, 255);" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" filter="url(#dropShadow)" ...

We call getElementsByTagName('*') on the svg element, which returns all descendant elements, but not the svg element itself. Therefore we have to handle the svg element separately.

So it has nothing to do with the complexity of the SVG, the same problem could occur in an extremely simple SVG if an id was references by an attribute of the svg element.

from svg-inject.

waruyama avatar waruyama commented on May 18, 2024

@ricardobr001 You can take the SVG offline if it was only uploaded for this issue report.

from svg-inject.

dasboe avatar dasboe commented on May 18, 2024

The fix is part of Version 1.2.2 which has just been released

from svg-inject.

ricardobr001 avatar ricardobr001 commented on May 18, 2024

It's working now on version 1.2.2, Thanks for the support guys!

from svg-inject.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.