Fixup deprecated coord_type [!10 merged]

[idaholab]

Fixup deprecated coord_type [!10 merged]

[moosebuild]

CIVET encountered an error retrieving branch icenct/malamute:fixup-deprecated.

This is typically caused by moosetest not having access to the repository.

Please grant Developer access to moosetest and try again.

[moosebuild]

In GitLab by @cticenhour on Aug 1, 2022, 10:56

requested review from @sapitts

[moosebuild]

In GitLab by @cticenhour on Aug 1, 2022, 11:00

@sapitts Could you give this a review? One thing to note here....Looking at 2a27b35d, some of the changes that were made by the VSCode formatter for parsed equations look a bit weird (e.g., numbers/coefficients within parsed functions being cut off in the middle if they don't fit in the prescribed line length). None of these changes affect usability or the final result, but they do look off. I can roll this back if you like, and will likely reach out to Daniel about it in the MOOSE extension repo.

[moosebuild]

In GitLab by @sapitts on Aug 1, 2022, 11:12

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal.i line 493

yeah, this could be a significant readability issue (4.418e-12 vs 418e-12). I agree that we need to reach out to Daniel.

In the meantime, can you manually move the numbers in front of the decimal down to the next line?

[moosebuild]

Job Documentation on 00fd2e3 wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage on 00fd2e3 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

[moosebuild]

In GitLab by @cticenhour on Aug 1, 2022, 14:18

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal.i line 493

Yeah, I can go through and fix these up as I find them. Link to the MOOSE language support extension issue: idaholab/moose-language-support#10

[moosebuild]

CIVET Testing summary for 2a27b35

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Test deprecated : Passed
Coverage : Passed

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal.i line 493

Bump the -4. to the second line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal.i line 512

move the exp(- to the third line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal_goofycontact.i line 493

move the -4. to the second line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal_goofycontact.i line 512

move the exp(- to the third line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/diemodel/electrothermal/electrothermal_plunger_powder.i line 233

move the -4. to the second line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/diemodel/electrothermal/electrothermal_plunger_powder.i line 252

move the exp(- to the third line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/diemodel/electrothermomechs/electrothermomechanical_plunger_powder_bothends_pressurebc.i line 304

move the -4. to the second line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:16

Commented on examples/sps/multiapp/diemodel/electrothermomechs/electrothermomechanical_plunger_powder_bothends_pressurebc.i line 323

move the exp(- to the third line please

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 09:19

Looks like it is pretty much the same two malformed lines with the autoformatting, and eventually I stopped marking the incidents. Could you grep / find-and-replace on those two lines for all the input files?

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 09:39

Sorry you went through and marked all these - I was already on it, but hadn't had the time to get back to it today. Thank you!

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal.i line 493

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal.i line 493

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal.i line 512

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal_goofycontact.i line 493

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/complete_geometry/electrothermal/engineering_scale_electrothermal_goofycontact.i line 512

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/diemodel/electrothermal/electrothermal_plunger_powder.i line 233

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/diemodel/electrothermal/electrothermal_plunger_powder.i line 252

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/diemodel/electrothermomechs/electrothermomechanical_plunger_powder_bothends_pressurebc.i line 304

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:46

Commented on examples/sps/multiapp/diemodel/electrothermomechs/electrothermomechanical_plunger_powder_bothends_pressurebc.i line 323

changed this line in version 2 of the diff

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:49

As mentioned in our chat - I removed the commit with these formatting changes. Might try this again if hit format behavior changes.

[moosebuild]

In GitLab by @cticenhour on Aug 2, 2022, 13:49

resolved all threads

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 13:51

Change in block for coord type commit looks good

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 13:51

approved this merge request

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 13:51

enabled an automatic merge when the pipeline for 00fd2e3 succeeds

[moosebuild]

CIVET Testing summary for 00fd2e3

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Test deprecated : Passed
Coverage : Passed

[moosebuild]

In GitLab by @sapitts on Aug 2, 2022, 14:15

mentioned in commit 366b898