Giter Site home page Giter Site logo

Comments (15)

iDevelopper avatar iDevelopper commented on July 3, 2024

I do not think it has anything to do with Swift's version. But maybe with iOS 11 new version and safe area and your constraints. Could you provide a sample here?

from pbrevealviewcontroller.

gramueller avatar gramueller commented on July 3, 2024

Sure in this swift file is only my basic navigation. it is already half a year old but i haven't changed anything when it comes to swreveal.
0.1 Navigation.zip

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 3, 2024

This project do not use PBRevealViewController but SW.

from pbrevealviewcontroller.

gramueller avatar gramueller commented on July 3, 2024

i know. i want to change to pbrevealcontroller with as less issues and as fast as possible or someone can help me with swreveal than i do not have to change :D

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 3, 2024

I don't know but there is no gap with PBRevealViewController:

Calimba.zip

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 3, 2024

The modified sample use PBRevealViewController version ObjC but you can use the Swift version.

from pbrevealviewcontroller.

graycampbell avatar graycampbell commented on July 3, 2024

I came across the same problem as @Wapasha. When revealController.isLeftPresentViewOnTop is set to false and the leftViewController is simply a UITableViewController with no navigation bar, there is a space between the top of the view and the status bar.

It happens on devices running iOS 11. It may also be a problem with earlier versions of iOS, but I haven't had a chance to check yet.

from pbrevealviewcontroller.

graycampbell avatar graycampbell commented on July 3, 2024

The gap also appears to always have a height of 20. Perhaps it's because of this method?

private func adjustsFrameForController(_ sideViewController: UIViewController) -> CGRect {
let barHeight = navigationBar.sizeThatFits(CGSize(width: CGFloat(100), height: CGFloat(100))).height
var frame: CGRect = sideViewController.view.frame
if (floor(NSFoundationVersionNumber) < 7.0) {
frame.origin.y = barHeight
frame.size.height = view.bounds.size.height - barHeight
}
else {
#if os(iOS)
let statusBarIsHidden: Bool = UIApplication.shared.statusBarFrame.size.height == 0.0
#else
let statusBarIsHidden: Bool = true
#endif
frame.origin.y = barHeight + (statusBarIsHidden ? 0 : 20)
frame.size.height = view.frame.size.height - barHeight - (statusBarIsHidden ? 0 : 20)
}
return frame
}

from pbrevealviewcontroller.

graycampbell avatar graycampbell commented on July 3, 2024

Never mind. It was a problem with how I was implementing the leftViewController and my constraints, so you can ignore my comments above. Sorry about that!

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 3, 2024

Ok no problem, I was about to answer.

from pbrevealviewcontroller.

gramueller avatar gramueller commented on July 3, 2024

I'm sry. I didn't have any time to answer lately. the version you send me still has a white bar on top. is there any way to remove this ?

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 3, 2024

This is the status bar. You can delete your first cell and embed your table view controller in a navigation controller.

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 3, 2024

If you want otherwise change the status bar background color you can use:

        guard  let statusBar = (UIApplication.shared.value(forKey: "statusBarWindow") as AnyObject).value(forKey: "statusBar") as? UIView else {
            return
        }
        statusBar.backgroundColor = yourColor

from pbrevealviewcontroller.

gramueller avatar gramueller commented on July 3, 2024

this is awesome! thank you very much. i will try it later and tell you if it worked.

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 3, 2024

This an example with navigation controller. And the customisation of nav bar is done in AppDelegate.swift.

Calimba-2.zip

from pbrevealviewcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.