Giter Site home page Giter Site logo

Comments (22)

iDevelopper avatar iDevelopper commented on July 22, 2024

You know the status bar is handled completely differently from iOS 7 by Apple. Already, as I can not do the test on iOS 6, I give you an answer for iOS 7 ++:

Embed your table view controller in a navigation controller, and in the navigation controller scene, uncheck "Shows Navigation Bar":

2016-08-31_20-35-31

What is Hotspot?

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

This flag is unchecked. Maybe problem is in my code bacause of manual frames adjusting... I'll check this

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

for iOS 6 we can do following fix as an workaround, because iOS 6 seems not to respect aligning to top layout guide (y = 20px) and it gives frame.origin.y = 20 on iOS 6, while on 9.3 it gives 0.
And if hotspot is active y = 40.
Hotspot is internet sharing from phone via WiFi or USB. Extra line 20px appears under status bar, if it is active.

- (void)perform
{
    NSString *identifier = self.identifier;
    PBRevealViewController *rvc = self.sourceViewController;
    UIViewController *dvc = self.destinationViewController;

    CGRect frame = dvc.view.frame;
    frame.origin.y = 0; // fix for iOS 6
    dvc.view.frame = frame;

    if ([identifier isEqualToString:PBSegueMainIdentifier]) {
        [rvc addChildViewController:dvc];
        [dvc didMoveToParentViewController:rvc];
        rvc.mainViewController = dvc;
    }
    else if ([identifier isEqualToString:PBSegueLeftIdentifier]) {
        rvc.leftViewController = dvc;
    }
    else if ([identifier isEqualToString:PBSegueRightIdentifier]) {
        rvc.rightViewController = dvc;
    }
}

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Hi @schmidt9 ,

Can you test these changes with the 6.0 version of iOS and keep me informed? Still missing rotation.

Classes.zip

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

I found an iPhone 4 running iOS 7.1.2. I'll try to make a downgrade to iOS 6.

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

I think you could make a new branch and apply changes for iOS 6 there, if you do not want change master, this way I could see what changes exactly you made, then you could merge this branch into master

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Yes, but in the files I sent to you, there is a // TODO comment for all changes.

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

Ok, I'll check it

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Hi @schmidt9 ,

Do you code in Objective-c or Swift?
Do you use CocoaPods for PBRevealViewController or not?

Because I'am doing some tests with a device on 7.1.2, and if I do not use CocoaPods, all is OK, but if I use it to integrate PBRevealViewController in a project, I get the error:

dyld: Symbol not found: OBJC_CLASS$_UIBlurEffect
Referenced from: /var/mobile/Applications/6EFBFB6A-1B18-401E-980E-BD3FFAD2C2D3/Example3Swift.app/Example3Swift
Expected in: /System/Library/Frameworks/UIKit.framework/UIKit
in /var/mobile/Applications/6EFBFB6A-1B18-401E-980E-BD3FFAD2C2D3/Example3Swift.app/Example3Swift

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

I don't use CocoaPods, so I cannot say what's wrong there, sorry. I use Objective C.

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

Currently have not much time to test code on iOS 6, hope to make it soon

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Ok, thank for reply. ++

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Hi @schmidt9 , I worked on iOS 6. When you have some time to test, I expect your feedback...

This is a sample project:

PBRevealiOS6.zip

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

Ok. Could you say what exactly to test?

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

The sample I posted and after your app but when you have time.

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

I tested your project, everything seems to work

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

I have not tried it in my app yet, maybe next days

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Thanks a lot!

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

Hello @iDevelopper I tested class from the sample project in my app, it works as expected, will you merge these changes to main branch?

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Hello @schmidt9 , Yes, I await your response. I'll do it this afternoon.

from pbrevealviewcontroller.

iDevelopper avatar iDevelopper commented on July 22, 2024

Done, pushed to master branch.

from pbrevealviewcontroller.

schmidt9 avatar schmidt9 commented on July 22, 2024

Thank you much!

from pbrevealviewcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.