Comments (4)
@Zewenaco Thank your for report , issue fixed
from idurar-erp-crm.
@salahlalami its the backend issue
https://github.com/idurar/erp-crm/blob/e670d2830d08b0c0b80d884f031f50b056cb075a/controllers/middlewaresControllers/createCRUDController/listAll.js#L17-L22
Whenever no invoice is there we are sending success as false .
from idurar-erp-crm.
Thanks for the reply, considering the code that you're mention. In my experience when an endpoint is returning a list or a pageable of element, if it's empty it should return success and the empty result. In this case, the backend return successfully ( an empty ) but yet successfully;
Should we refactor this to return another http code or just change the sucess value? WDYT?
It could be more suitable if the method return 204 in case of empty collection?
from idurar-erp-crm.
Thanks for the reply, considering the code that you're mention. In my experience when an endpoint is returning a list or a pageable of element, if it's empty it should return success and the empty result. In this case, the backend return successfully ( an empty ) but yet successfully;
Should we refactor this to return another http code or just change the sucess value? WDYT? It could be more suitable if the method return 204 in case of empty collection?
In my view status code is correct , succes needs to refactor as we are refferencing only succes here
https://github.com/idurar/erp-crm/blob/e670d2830d08b0c0b80d884f031f50b056cb075a/frontend/src/redux/erp/actions.js#L47-L66
from idurar-erp-crm.
Related Issues (20)
- Site Not Responsive On Mobile Browsers HOT 2
- Dark mode in the application HOT 9
- Inconsistent French Translation on Website HOT 5
- report button does not exist in the repo so we cannot fix the issue of translation HOT 1
- Consolidate Frontend and Backend Run Scripts into a Single Script HOT 3
- Show charts and expenses on relevant sections HOT 1
- Can't save notes in oportunities HOT 1
- cannot delete clients HOT 3
- Consider Using TypeScript and Tailwind CSS HOT 2
- Facilitating the enable button in products category HOT 1
- Phone field accepts any character HOT 2
- Dark Mode HOT 1
- AutoComplete Control Not Updating Selected Value HOT 1
- when Adding Product Category Error shows "Please enter Enabled" in enabled field
- Feature Request: Add Robot Verification HOT 4
- Enhance Lead Management with Campaign Management Feature
- Suggestion: Use of User Persona Fatima El Amri for Feature Development
- Dark/Light Mode HOT 4
- After deploying backend on render.com error happens: "Api url doesn't exist"
- [BUG] Colour changes into white while hovering HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from idurar-erp-crm.