Giter Site home page Giter Site logo

Comments (5)

AlexB67 avatar AlexB67 commented on July 17, 2024 1

My suggestion was for this program, not for yours, as I don't know yours :)

I can point for you to this: https://github.com/CrawfordGroup/ProgrammingProjects though, I doubt you implemented everything suggested there.

I started to add some things to mine from those suggestions, dipole integrals, population analysis, Moller-Plesset, CCSD(T) and DIIS. Hopefully this year CIS and TDHF/RPA will follow, maybe also Davidson-Liu.

Thanks, Yes, i am aware of the links, It' s where I stared from. I implemented them all (CCSD can be done much faster for closed shell than is described there. See https://pycrawfordprogproj.readthedocs.io/en/latest/Project_05/Project_05.html for all needed equations) except for the DL algorithm.

Instead I focused on first and second derivative integrals to calculate gradients and the Hessian for geometry optimisation/frequencies (Cant get away from my spectroscopic roots, got to have them frequencies ::D ) , which I have implemented up to MP2 level. Much help can be found in the psi4numpy tutorials too.

It'll be uploaded one of these days/weeks/months .. but I keep adding and never feel it is quite done. but it's getting closer. I would like to optimise my integral code a bit more and do it in shells instead of per basis function before uploading.

from hfcxx.

ifilot avatar ifilot commented on July 17, 2024 1

Thank you for reporting this error. The erroneous line

addGTO_px(0.3134706954, 0.42585954770000001,r);

has been replaced by

addGTO_pz(0.3134706954, 0.42585954770000001,r);

The STO-6g calculation of benzene has furthermore been added to the test suite.

from hfcxx.

aromanro avatar aromanro commented on July 17, 2024

As the difference between STO3G and STO6G is not that big, only the number of gaussians are different, I suspected a basis error and it appears I found something https://github.com/ifilot/hfcxx/blob/master/src/basis-sto6g.cpp#L199:

    if(type.compare("2pz")==0 && z==6) {
        addGTO_pz(30.497239499999999, 0.0037596966000000001,r);
        addGTO_pz(6.0361996009999999, 0.037679369800000001,r);
        addGTO_pz(1.876046337, 0.17389674350000001,r);
        addGTO_pz(0.72178264700000005, 0.41803643470000001,r);
        addGTO_px(0.3134706954, 0.42585954770000001,r);
        addGTO_pz(0.14368655499999999, 0.1017082955,r);
    }

It's a typo, addGTO_px should be addGTO_pz.

It's a nice program, I used it to compare some values from the computations with mine.

By the way, as a suggestion, it's not a big change to load the basis sets from files instead of hardwiring them in the code.
I did that and I can load various basis sets:
https://github.com/aromanro/HartreeFock

from hfcxx.

AlexB67 avatar AlexB67 commented on July 17, 2024

As the difference between STO3G and STO6G is not that big, only the number of gaussians are different, I suspected a basis error and it appears I found something https://github.com/ifilot/hfcxx/blob/master/src/basis-sto6g.cpp#L199:

    if(type.compare("2pz")==0 && z==6) {
        addGTO_pz(30.497239499999999, 0.0037596966000000001,r);
        addGTO_pz(6.0361996009999999, 0.037679369800000001,r);
        addGTO_pz(1.876046337, 0.17389674350000001,r);
        addGTO_pz(0.72178264700000005, 0.41803643470000001,r);
        addGTO_px(0.3134706954, 0.42585954770000001,r);
        addGTO_pz(0.14368655499999999, 0.1017082955,r);
    }

It's a typo, addGTO_px should be addGTO_pz.

It's a nice program, I used it to compare some values from the computations with mine.

By the way, as a suggestion, it's not a big change to load the basis sets from files instead of hardwiring them in the code.
I did that and I can load various basis sets:
https://github.com/aromanro/HartreeFock

Thanks
Yeah I already load basis sets from files too. Mine reads psi4 compatible basis sets. I used hfcxx earlier on to compare answers. looks like you found it anyway. :)

from hfcxx.

aromanro avatar aromanro commented on July 17, 2024

My suggestion was for this program, not for yours, as I don't know yours :)

I can point for you to this: https://github.com/CrawfordGroup/ProgrammingProjects though, I doubt you implemented everything suggested there.

I started to add some things to mine from those suggestions, dipole integrals, population analysis, Moller-Plesset, CCSD(T) and DIIS. Hopefully this year CIS and TDHF/RPA will follow, maybe also Davidson-Liu.

from hfcxx.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.