Comments (6)
Thanks for the review! No issues with any of your feedback, will get an updated PR pushed in the next day or so.
from cog.
For example in this commit in MPV there is some handling of the scaling reported by the Wayland compositor to make sure things are rendered properly. I suspect WPE WebKit (or the WPE FDO backend) are missing something like that, so I have filed an issue upstream:
Let's keep this one open in case we need to add some support code in Cog's FDO platform plug-in as well.
from cog.
This will a version of libwpe which includes WebPlatformForEmbedded/libwpe#44 and some support code in cog-platform-fdo.c
to inform WPE WebKit about the device scaling factor reported by Wayland.
from cog.
WebKit HiDPI patch landed at r245394.
from cog.
I have just reviewed #94 (sorry about the delay), and I must say that @tokyovigilante has been doing a terrific contribution here, touching all the needed parts in the different components (libwpe, WebKit, etc). Kudos to him 🏅
from cog.
Ok, 300b48d should hopefully do it. I've also fleshed out registry_global_remove
to deregister an output if it's removed from the system (ie monitor hotplug). Let me know if there are any more style issues, I commit here and there to a few projects and I do miss the odd convention, sorry!
from cog.
Related Issues (20)
- VPU not used with cog HOT 12
- Disentangle CogShell from CogPlatform
- When drawing a pixel, also the pixel above is impacted HOT 2
- Difference handling needed on Visibility vs Focus for the Views
- Meson configure error when Cog is build only for wayland
- Missing cog-export.h header in the cogcore_headers
- gtk4: Pointer coordinates wrongly reported when the window is on a monitor with fractional scaling HOT 1
- [Clean-up] Remove redundant platform safe-guards in core
- Remove cog_platform_init_web_view() from the API
- MouseEvent buttons property not set in wayland backend
- Crash calling wl_pointer_set_cursor() in cog-utils.c HOT 2
- /snap/wpe-webkit-mir-kiosk/101/usr/bin/cog memory increases until it crashes.
- Identifiers for touch points are not constant in multi touch HOT 5
- cog flickering and not HW accelerated on NXP iMX8M-Plus HOT 2
- Latest COG w/DRM backend has no focus HOT 2
- [wpe-2.38.5][wpe-webkit-mir-kiosk] Long touch/press not working
- (wpe-webkit-mir-kiosk) - Launch homepage on idle HOT 3
- DRM key-repeat only repeats once
- Is DRM missing cog_launcher_get_viewport()?
- cogctl ping fails but reload etc works
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cog.