Giter Site home page Giter Site logo

Comments (6)

tokyovigilante avatar tokyovigilante commented on July 22, 2024 1

Thanks for the review! No issues with any of your feedback, will get an updated PR pushed in the next day or so.

from cog.

aperezdc avatar aperezdc commented on July 22, 2024

For example in this commit in MPV there is some handling of the scaling reported by the Wayland compositor to make sure things are rendered properly. I suspect WPE WebKit (or the WPE FDO backend) are missing something like that, so I have filed an issue upstream:

Let's keep this one open in case we need to add some support code in Cog's FDO platform plug-in as well.

from cog.

aperezdc avatar aperezdc commented on July 22, 2024

This will a version of libwpe which includes WebPlatformForEmbedded/libwpe#44 and some support code in cog-platform-fdo.c to inform WPE WebKit about the device scaling factor reported by Wayland.

from cog.

tokyovigilante avatar tokyovigilante commented on July 22, 2024

WebKit HiDPI patch landed at r245394.

from cog.

aperezdc avatar aperezdc commented on July 22, 2024

I have just reviewed #94 (sorry about the delay), and I must say that @tokyovigilante has been doing a terrific contribution here, touching all the needed parts in the different components (libwpe, WebKit, etc). Kudos to him 🏅

from cog.

tokyovigilante avatar tokyovigilante commented on July 22, 2024

Ok, 300b48d should hopefully do it. I've also fleshed out registry_global_remove to deregister an output if it's removed from the system (ie monitor hotplug). Let me know if there are any more style issues, I commit here and there to a few projects and I do miss the odd convention, sorry!

from cog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.