Syntax support for config-like files

[ignatov]

Syntax support for config-like files

[vovakyrychenko]

This is not correct.

Not all *.config files are Rebar configuration files. There are reltool.config, sys.config, etc. So this files should not be marked as "rebar" unless it's "rebar.config" in particular.

It's not tuples. It could be anything that file:consult parses. file.consult parses list of dot terminated terms not tuples:

a.
[x,y].
{z}.     

file:consult("x.conf").
{ok,[a,[x,y],{z}]}

[vovakyrychenko]

Those are not Erlang files. Those are files with Erlang terms. Current BNF allows expressions like {2+2}. It wont be parsed by file:consult.

I believe for this type of files there should be whole another grammar.

[ignatov]

OK, but at the moment I think that is better to highlight those files. Thought?

[vovakyrychenko]

Yes. But as it implemented now it erroneously highlight errors in correct files:

x.

and does not highlight errors with 'correct Erlang':

f() -> x.

And it's not rebar:)

[ignatov]

So, if I now change the grammar to

root ::= form *
form ::= (is_app_config expression) | (!is_app_config erlang_form)
erlang_form ::= function | rule | record_definition | include | macros_definition | attribute

it'll be OK?

[vovakyrychenko]

It will allow different kinds of expressions (try, send, assignment, arithmetical) in there which is not allowed by file:consult. There should be terms, not expressions. The only things allowed there are unary '+' and unary '-'.
See https://github.com/erlang/otp/blob/maint/lib/stdlib/src/erl_parse.yrl parse_term() and normalize().

[vovakyrychenko]

one other thing - there could be comments inside. This one is perfectly fine

{
    x, 
%aaaaa
    y %xxxxxxx
}.

[vovakyrychenko]

BTW there are community provided erlang file types in intellij platform - can you make some moves to make these config go away? They're kinda conflicting with plugin making wrong icons to be shown sometimes.