formatting errors round 3

[ignatov]

formatting errors round 3

[ignatov]

What's wrong with the first item?
Сan be arithmetic expressions places within the attributes? If not, I'll fix the first item as well.

[vovakyrychenko]

it's a name/arity for functions and types. Same as -export([x/1]). Arithmetic expressions could not be put there to my knowledge. -attr(2/2) wont compile.

[ignatov]

OK, I see, erlc reports an error 'bad attribute' for -attr(2/2).I'll fix the first one item.

[vovakyrychenko]

no spaces in record fields assignment. There should be ones

    #x{
        id = <<"1">>,
        x = y
    }

[vovakyrychenko]

extra tab of closing curly

-record(x, {
    x
}).

[ignatov]

no spaces in record fields assignment. There should be ones

    #x{
        id = <<"1">>,
        x = y
    }

In standart library variant without spaces around = within record field is more frequent. So, this space is a good candidate for code style preferences. At the moment, I leave variant without spaces.

[vovakyrychenko]

But it introduces compilation errors into syntactically correct code. This makes formatter unusable if there are binaries assigned to record fields - after formatting code wont compile - try this example:

-record(x, {
    x, id
}).
f() ->
   #x{
        id = <<"1">>,
        x = y
    }.

[ignatov]

OK, I got your point.