Giter Site home page Giter Site logo

Comments (7)

gaborcsardi avatar gaborcsardi commented on August 23, 2024

(by gabor.csardi)
This change is probably too big for version 0.6, let's postpone it to 0.7.

from rigraph.

gaborcsardi avatar gaborcsardi commented on August 23, 2024

With the repaired vs and es indexing returning vs and es seems to be possible. The problem is that these return values cannot be used with modified graph objects. (But they should not be used, anyway.)

But a lot of functions return vertex/edge ids, do we want to change all of them? Here are all of them, unless I forgot some:

  • all_shortest_paths
  • articulation_points
  • bfs
  • biconnected_components
  • blocks
  • canonical_permutation
  • cliques
  • dfs
  • dominator_tree
  • ego
  • ends
  • farthest_vertices
  • fit_hrg
  • get_diameter
  • girth
  • graphlet_basis
  • graphlets
  • groups
  • head_of
  • incident
  • ivs
  • largest_cliques
  • largest_ivs
  • max_cardinality
  • max_cliques
  • max_flow
  • maximal_ivs
  • min_cut
  • min_separators
  • min_st_separators
  • neighbors
  • predict_edges
  • shortest_paths
  • st_cuts
  • st_min_cuts
  • subcomponent
  • tail_of
  • topo_sort
  • triangles
  • unfold_tree

from rigraph.

gaborcsardi avatar gaborcsardi commented on August 23, 2024

https://github.com/igraph/igraph/tree/return-vs-es

from rigraph.

gaborcsardi avatar gaborcsardi commented on August 23, 2024

groups is tricky, because it is not called on the graph. If we want a vs there, then we need to call groups on the graph (as well):

clu <- components(g)
groups(g, clu)

from rigraph.

gaborcsardi avatar gaborcsardi commented on August 23, 2024

One big problem is that when one saves an object to a file, the whole graph is saved, too. So returning vs/es is a bad idea..... :( We should return vertex names instead.

from rigraph.

gaborcsardi avatar gaborcsardi commented on August 23, 2024

This is mostly sorted out by now, with weak references.

from rigraph.

github-actions avatar github-actions commented on August 23, 2024

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

from rigraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.