Giter Site home page Giter Site logo

ReplayGain support about iina HOT 5 OPEN

MrSimmo avatar MrSimmo commented on July 23, 2024
ReplayGain support

from iina.

Comments (5)

low-batt avatar low-batt commented on July 23, 2024 2

Really nice writeup of the requested feature.

The request is to add UI support for the mpv replaygain option:

--replaygain=<no|track|album>
Adjust volume gain according to replaygain values stored in the file metadata. With --replaygain=no (the default), perform no adjustment. With --replaygain=track, apply track gain. With --replaygain=album, apply album gain if present and fall back to track gain otherwise.

I'm assuming it is desirable to also include support for the associated options:

from iina.

low-batt avatar low-batt commented on July 23, 2024 1

Please have a look at the screenshots of the proposed implementation in PR #4932. Does that look like what you were expecting? Does the mpv behavior I show look like ReplayGain is working?

from iina.

MrSimmo avatar MrSimmo commented on July 23, 2024

Please have a look at the screenshots of the proposed implementation in PR #4932. Does that look like what you were expecting? Does the mpv behavior I show look like ReplayGain is working?

This is brilliant - looks great! Yup, looks like its working fine. Thank you again

from iina.

low-batt avatar low-batt commented on July 23, 2024

Very helpful that you entered this issue. I was unaware of this mpv feature.

I'm a junior IINA developer so the proposed changes still need to be reviewed by the other developers. Future release plans are always subject to change, but last I heard the next release will be a bug fix release, so unlikely this change will make it into that release. As soon as possible after that release will be the first beta release for the long planned feature release. I'm expecting this change will make it into that release.

from iina.

MrSimmo avatar MrSimmo commented on July 23, 2024

Thanks low-batt; sounds good! and thanks again

from iina.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.