Giter Site home page Giter Site logo

Comments (4)

low-batt avatar low-batt commented on June 29, 2024 1

Since we are being forced to touch it I think we should adhere to secure coding as that is a good thing to do. The changes in that commit are part of what is needed. I have some of the changes needed for secure coding. It is looking like that won't require database migration and should not be hard to implement. I am doing some testing at the moment.

from iina.

low-batt avatar low-batt commented on June 29, 2024 1

@svobs By the way, the big mpv / FFmpeg upgrade was just merged. You will need to download new libs once you pull develop.

from iina.

svobs avatar svobs commented on June 29, 2024

Correcting these warnings requires changing PlaybackHistory to implement NSSecureCoding and then changing the methods in HistoryController that read and save history. I believe this will require the history database to be migrated.

Is the goal to migrate to secure coding, or just to get rid of the warnings? Here are the changes I made to do the latter: 8e11e11

from iina.

low-batt avatar low-batt commented on June 29, 2024

@svobs Please have a look at the proposed fix. I used some of the changes from your commit and added code to support secure coding.

from iina.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.