Giter Site home page Giter Site logo

Comments (2)

wbunting avatar wbunting commented on May 17, 2024

It would also be pretty sick to get this set up with Deploy Hooks. That way if your preview looks good you can click "rebuild SSG" or something to sync up to production

from notion-blog.

ijjk avatar ijjk commented on May 17, 2024

Hi, the changes on your fork look awesome, I would definitely appreciate a PR with those changes!

A few things I noticed that can be updated:

  • combine api/clear-preview and api/clear-preview-post into a single endpoint and redirect to /blog if no slug query value
  • the exit preview mode button looks like it could use flex-direction: column to make sure the text is centered vertically
  • the fallback state for lazy blog posts isn't currently handled, we'll want to show a loading state when useRouter().isFallback is true

Feel free to open the PR and I can help tweak these things if you'd like, thanks for looking into this!

from notion-blog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.