Additional fields when parsing primary.xml

[ikapelyukhin]

Additional fields when parsing primary.xml

[ikapelyukhin]

Hey, 2D. 👋

Anything planned here already?

Nothing planned, because those other fields aren't used anywhere else (e.g. RMT or repo-tools).

Can we have these?

Sure, especially if you add them yourself 🙂

I can do a draft PR, just wanted to ask your opinion. Should I just add parsing these fields always, or attempt something like optional "extra_fields"?

Something optional could be nice (maybe supplying an optional code block that does additional parsing -- the actual values are sometimes an XML element attribute and sometimes element's text()), but the list of fields is hardcoded into RepomdParser::Reference class definition, having those defined dynamically kind of defies the purpose of having that class at all. Besides, the set of possible fields is very limited (it's not like you can add a random XML property to SUSE repos).

So right now I'm gravitating towards just adding those fields, it is the way of least resistance. 🙂 I'd recommend testing with RES repos and making sure nothing breaks, though -- RedHat repos have a slightly different XML format.