Http Status code of the response is not returned correctly from the cache

[ikyriak]

Http Status code of the response is not returned correctly from the cache

[ikyriak]

Hello @MohamadTahir
Thanks for taking the time to report this issue and the workaround! 👍 🙏

[MohamadTahir]

Always welcome @ikyriak

there is another thing, after doing some search I realized that unsuccessful responses should not be cached when implementing idempotency, why? what if a transient error occurred? the user should be able to process the same quest with the same idempotency key, this package behaves correctly when the error occurs before reaching the controller, what do I mean by this?

so let's say that we have a request model like the following

public record SampleModel
{
    [MinLength(3)]
    public int[]  { get; set; } = Array.Empty<int>();
}

if the user sends a request and the array size is 2, then the request won't go inside the controller and will return 400, in this case, the package won't cache the response, which is the correct behavior.

but what if the user sent an array of size 4, there will be no validation errors and the request will go into the controller, in there we do our own validation on the data that has been provided in the array then decide that we need to return the NotAcceptableResult response for whatever reason, in this case, since the request is returned from within the controller it will be cached by the package, which is not the behavior that we look for.

[ikyriak]

Hello @MohamadTahir

The issue of the NotAcceptedObjectResult will be fixed in the following major release, as you have provided a workaround for the moment.

Regarding the "unsuccessful responses should not be cached":

In the 1.0.2-prerelease-01 version, you can set the CacheOnlySuccessResponses attribute option to true/false. Currently, the default is false not to change the current behavior. However, the default value will be true in the following major release. You can see more details in issue #37.

Is this behavior working for your case?

[MohamadTahir]

Perfect, that's what we want, we want to cache only successfully responses

[ikyriak]

Hello @MohamadTahir,

The fix for the NotAcceptedObjectResul issue has been released in v2.0.0-RC.01 🎆 🎉 . Could you please verify that it's OK?