java.lang.IllegalStateException: close() has been called on the Graph

[imagej]

java.lang.IllegalStateException: close() has been called on the Graph

[frauzufall]

Thanks for the feedback @ctrueden, I made the suggested changes which also restore backwards compatibility by introducing a new loadCachedModel method and deprecating loadModel, see PR #24

[ctrueden]

@frauzufall The SavedModelBundle is not a final class, so we can create a subclass ImageJSavedModelBundle extends SavedModelBundle and override close() to invalidate itself from the cache. And then make sure the TensorFlowService always wraps models it loads.

[frauzufall]

@ctrueden thanks, I tried it but the SavedModelBundle constructor is private.. Any way around that?

[frauzufall]

An alternative would be some kind of reflection hack to make SavedModelBundle usable. Is that better than releasing 2.0.0?

[ctrueden]

Hmm, too bad. OK, so then we can use composition rather than inheritance. Make our own model class that also implements AutoCloseable and does the right cleanup when close() is called, and has a method SavedModelBundle model() to access the TensorFlow SavedModelBundle. When our model class's close() method is called, it also calls close() on the wrapped SavedModelBundle. Only pass around our model objects with our API.

[ctrueden]

I merged #24, so closing this.