Comments (6)
Thanks for the feedback @ctrueden, I made the suggested changes which also restore backwards compatibility by introducing a new loadCachedModel
method and deprecating loadModel
, see PR #24
from imagej-tensorflow.
@frauzufall The SavedModelBundle
is not a final class, so we can create a subclass ImageJSavedModelBundle extends SavedModelBundle
and override close()
to invalidate itself from the cache. And then make sure the TensorFlowService
always wraps models it loads.
from imagej-tensorflow.
@ctrueden thanks, I tried it but the SavedModelBundle
constructor is private.. Any way around that?
from imagej-tensorflow.
An alternative would be some kind of reflection hack to make SavedModelBundle
usable. Is that better than releasing 2.0.0
?
from imagej-tensorflow.
Hmm, too bad. OK, so then we can use composition rather than inheritance. Make our own model class that also implements AutoCloseable
and does the right cleanup when close()
is called, and has a method SavedModelBundle model()
to access the TensorFlow SavedModelBundle
. When our model class's close()
method is called, it also calls close()
on the wrapped SavedModelBundle
. Only pass around our model objects with our API.
from imagej-tensorflow.
I merged #24, so closing this.
from imagej-tensorflow.
Related Issues (14)
- Cached models only compared by name and tag HOT 4
- Add options dialog to control CPU/GPU mode, and graphics card selection
- Feature Request: Object Detection or Instance Segmentation HOT 1
- Add cache clearing API
- Cache system variable improvements
- Try to implement the TensorFlow version control in my code HOT 1
- Upgrade to TensorFlow 2
- jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class java.net.URLClassLoader HOT 2
- install tensorflow through script interface HOT 1
- Use ByteBuffers for all image types HOT 2
- Cache directory location during development HOT 5
- Policy for NN models distribution HOT 3
- Using GPU with TensorFlow HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imagej-tensorflow.