Deleting an accepted annotation from the history does not delete annotation

[reckart]

Deleting an accepted annotation from the history does not delete annotation

[reckart]

@betoboullosa @matchlesswei What do you think about this?

[betoboullosa]

I think it might make sense, but maybe it's not entirely clear to the user that deleting from the history also deletes the annotation. A possible help would be showing a warning like this: "Attention, this action will also delete the corresponding annotation. Proceed?".

[matchlesswei]

• first jump to the annotation
• then delete that annotation

[reckart]

We have a reusable ConfirmationDialog which could be used here.

[matchlesswei]

@reckart so you mean 1. jump to the annotation 2. ask the user for confirmation 3. delete the annotation?

[reckart]

Aye. That would incorporate @betoboullosa valid concern.

[matchlesswei]

@betoboullosa @reckart the confirmationDialog only shows up before deleting the annotation? Or it shows up everytime the user clicks the trash bin in the learning history?

[reckart]

Only for accepted annotations if the deletion from the history also triggers a deletion of the actual annotation.

[reckart]

AnnotationDetailEditorPanel.actionDelete(AjaxRequestTarget) (or via AnnotationActionHandler interface) should be used to trigger the deletion. Mind this might cause a second confirmation dialog to pop up if deleting the annotation triggers the deletion of further annotations (e.g. relations attached to the deleted span).

[matchlesswei]

@reckart @betoboullosa
Do we ask for a confirmation to delete the history and annotation(if user choose cancel, then history is kept)?
Or do we delete that history without confirmation, then ask for a confirmation to delete the annotation?

[reckart]

I would say just for the annotation. The history item would be deleted anyway.