Comments (3)
martin-g:
I use the following fix locally to avoid the NPE. Not sure it is the correct one though
private BigDecimal maxOf(BigDecimal max, final BigDecimal summaryMax) {
- return max != null ? max.max(summaryMax) : summaryMax;
+ return max != null
+ ? summaryMax != null
+ ? max.max(summaryMax)
+ : max
+ : BigDecimal.ZERO;
}
private BigDecimal minOf(BigDecimal min, final BigDecimal summaryMin) {
- return min != null ? min.min(summaryMin) : summaryMin;
+ return min != null
+ ? summaryMin != null
+ ? min.min(summaryMin)
+ : min
+ : BigDecimal.ZERO;
}
from incode-platform.
danhaywood:
possibly not; what if every value is null? The result ought to be null,
but I think this code might give BigDecimal.ZERO.
On 9 October 2014 09:02, Martin Grigorov [email protected] wrote:
I use the following fix locally to avoid the NPE. Not sure it is the
correct one thoughprivate BigDecimal maxOf(BigDecimal max, final BigDecimal summaryMax) {- return max != null ? max.max(summaryMax) : summaryMax;+ return max != null+ ? summaryMax != null+ ? max.max(summaryMax)+ : max+ : BigDecimal.ZERO; } private BigDecimal minOf(BigDecimal min, final BigDecimal summaryMin) {- return min != null ? min.min(summaryMin) : summaryMin;+ return min != null+ ? summaryMin != null+ ? min.min(summaryMin)+ : min+ : BigDecimal.ZERO; }
—
Reply to this email directly or view it on GitHub
isisaddons-legacy/isis-wicket-wickedcharts#2 (comment)
.
from incode-platform.
martin-g:
returning null
instead of BigDecimal.ZERO
seems to do the job as well
from incode-platform.
Related Issues (20)
- Remove pdfbox vulnerability
- Remove camel validation vulnerability
- Remove camel-jackson vulnerability
- Allow minio to archive more than one blob per source entity.
- Bump to jackson 2.9.8 to fix security vulnerabilities
- Make minio uploader/downloaders more resilient, automatically reconnecting if necessary
- ExcelConverter casts to short where it does not make sense
- Unknown host repository-estatio.forge.cloudbees.com - Apache isis HOT 2
- If PublisherMq fails to send event, just continue anyway rather than throw an exception.
- convert documentation to use Antora
- Security Module Vulnerability: Non-existing User gets created in DB even though not authenticated via LDAP HOT 4
- Enhance publishmq module to support the outbox pattern.
- Minio blob archiver
- Please update FakeDataService to use the latest JavaFaker dependency
- Fix javassist dependency in incode quickstart
- Add a Wicket tree table (hierarchical) view HOT 1
- isis-module-excel-dom add column order HOT 1
- Wicket Viewer throws error when JDO Application Identity is used HOT 2
- Allow PublishMqService to be disabled via configuration property.
- Customized ContentMappingService does not take effect HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from incode-platform.