Comments (13)
What suggestions do you have? The nice thing about this project is that you could just use lib/bn.js
in a browser.
from bn.js.
I only have suggestions that compromise that capability.
from bn.js.
I would suggest to provide a minified version. That would reduce the amount a bit but I donΒ΄t see it much as an issue.
from bn.js.
@chevdor my concern isn't size in part of distribution or use in production.
My concerns were primarily in being able to review and audit a project which consists entirely of a 2000+ SLOC file.
In any other language, this could [probably] be considered a failure in the projects architecture.
from bn.js.
After some consideration: I don't mind if it'll be split into the multiple files, provided that there will be a all-included js distribution, and the way to include all plugins would be simple/transparent for users.
@dcousens any suggestions how to do it?
from bn.js.
I think just a flat file structure based on the different context classes
should be enough?
On 27 Mar 2015 4:32 am, "Fedor Indutny" [email protected] wrote:
After some consideration: I don't mind if it'll be split into the multiple
files, provided that there will be a all-included js distribution, and the
way to include all plugins would be simple/transparent for users.@dcousens https://github.com/dcousens any suggestions how to do it?
β
Reply to this email directly or view it on GitHub
#35 (comment).
from bn.js.
Yeah, this sounds awesome. Does it sound like an interesting project to you? ;)
from bn.js.
Sure, I'll wait for you to merge #27 to save me an annoying rebase/merge effort.
from bn.js.
Its a shame you can't assign issues to people involved in the conversation.
from bn.js.
@dcousens #27 has been merged π
from bn.js.
This PR was hanging this for one year! :)
from bn.js.
Haha. I'll get around to this some time soon then π
from bn.js.
I suspect this is probably never going to be worth the time considering the relative stability of this code now.
from bn.js.
Related Issues (20)
- Easiest way to get percentage HOT 10
- muln with fractional number gives wrong result HOT 3
- Add method for "not equal"
- Assertion failure error message could be helpful
- Use bn.js instead of bignumber.js
- Incorrect multiplication result when using muln() HOT 1
- Converting json.stringified BN back into BN HOT 2
- use in web HOT 1
- TypeError: bn_js_1.default is not a constructor
- Add support for raising a `BN` object to the power of a plain JavaScript Number
- Function `mod` gives incorrect results when the arguments are of opposite signs
- setn function signature in index.tx doesn't correspond with the library HOT 1
- Which rounding method is used?
- Base64 encoding
- Wrong `cmpn` result HOT 1
- The unit of length in `toBuffer(endian, length)` is unclear
- Property 'divmod' does not exist on type 'BN'
- Add link to library this is based on to docs
- BN.muln with number bigger than 0x4000000 HOT 1
- I'm gonna find every one of you
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bn.js.