Comments (8)
It throws now.
from bn.js.
The same applies to parseHex
(as basically it is the same code as parseBase
, with one exception: range is limited to f/F).
new BN('1234', 16) // <BN: 1234>
new BN('12.34', 16) // <BN: 12e34>
from bn.js.
I know that it should throw, but it doesn't right now. The thing is that this is an big integer library, so you should not really pass data like this to it.
from bn.js.
I do know that and I don't pass those kind of numbers. However, users of my library are. I can either do pre-processing there which is quite big of an overhead. I would prefer bn.js to throw, I have the PR ready, will submit it soon - it is quite small.
from bn.js.
A note on the integer side, the library's name is short for big number and doesn't specifically mentions anywhere it is integers and not decimals. I know that, but it is not clear from the first sight at the README, maybe it should be updated.
from bn.js.
Yeah, I totally agree. It should be updated. Thanks!
from bn.js.
new BN(4.2)
return <BN: 4>
also should be assert here
from bn.js.
A note was added to the README at some point
Note: decimals are not supported in this library.
from bn.js.
Related Issues (20)
- Easiest way to get percentage HOT 10
- muln with fractional number gives wrong result HOT 3
- Add method for "not equal"
- Assertion failure error message could be helpful
- Use bn.js instead of bignumber.js
- Incorrect multiplication result when using muln() HOT 1
- Converting json.stringified BN back into BN HOT 2
- use in web HOT 1
- TypeError: bn_js_1.default is not a constructor
- Add support for raising a `BN` object to the power of a plain JavaScript Number
- Function `mod` gives incorrect results when the arguments are of opposite signs
- setn function signature in index.tx doesn't correspond with the library HOT 1
- Which rounding method is used?
- Base64 encoding
- Wrong `cmpn` result HOT 1
- The unit of length in `toBuffer(endian, length)` is unclear
- Property 'divmod' does not exist on type 'BN'
- Add link to library this is based on to docs
- BN.muln with number bigger than 0x4000000 HOT 1
- I'm gonna find every one of you
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bn.js.