Comments (9)
@megaandros You're correct that it's a workaround, but I'd argue that downgrading to Node 17 isn't a proper fix to "Error on Node 18".
It should also be noted that Node 17 goes end-of-life on June 1, i.e. in just 29 days.
from node-ip.
This should be fixed in the latest release. Sorry it took me so long to get to it.
from node-ip.
see also nodejs/node#41431 (review)
from node-ip.
Found issue in the "ip.js" code where family variable value coming in value.
fix
On line 386 do following change
if(!isNaN(details.family)){
details.family = ((details.family == 4)?"ipv4":"ipv6");
}
details.family = details.family.toLowerCase();
from node-ip.
@jaiswarvipin The fix is easy ... The problem is that this library is used in many others, so it would need new versions of this lib with the fix to be really useful
from node-ip.
noted.
Currently not able to create / check-in as separate branch with new version, its giving access denied.
warning: ΓöîΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇ SECURITY WARNING ΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÉ
warning: Γöé TLS certificate verification has been disabled! Γöé
warning: ΓööΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÿ
warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information.
info: please complete authentication in your browser...
warning: ΓöîΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇ SECURITY WARNING ΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÉ
warning: Γöé TLS certificate verification has been disabled! Γöé
warning: ΓööΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÿ
warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information.
remote: Permission to indutny/node-ip.git denied to jaiswarvipin.
fatal: unable to access 'https://github.com/indutny/node-ip.git/': The requested URL returned error: 403
from node-ip.
Proposed fix for IPV4 and IPv6 (Single m/c/ Scale set, Kubernetes, Mobile Device) working as expected. Kindly merge the code base in main branch
from node-ip.
The issue can be fixed with node.js = v.17.9.0
How to downgrade - https://stackoverflow.com/questions/58280757/how-to-upgrade-node-to-specific-version-in-macos-mojave-and-update-the-active-p
from node-ip.
Thank you very much(indeed ... the nodejs guys discuss reverting this breaking change btw ;-)))) ... but still anything ok with how you fixed it
from node-ip.
Related Issues (20)
- Unexpected identifier HOT 9
- [BUG] error: var numberOfAddresses = 2 ** (32 - maskLength); SyntaxError: Unexpected token * HOT 3
- Version 2.0.0 is not marked as latest
- Add LICENSE.md
- Private IPv4 mapped regions are only matched in dot-notation
- IPv6 to Int or Long
- V2.0.0 Broke the support for older Node versions
- Found a possible security concern HOT 1
- Incompatibilty with webpack 5 because of missing polyfills
- Project Dead? Does it need more maintainers? HOT 5
- How to verify and validate ip/cidr? HOT 1
- Buffer is not a constructor HOT 1
- isPrivate should include 198.18.0.0/15
- isV6Format returns true with IPv4 input
- 🚨 HIGH Severity Vulnerability: Package unsafe for use as of v1.1.8 🚨 HOT 25
- Semantic of `address()` is wrong HOT 1
- Breaking changes - isPrivate and isPublic now throws HOT 1
- NPM IP package incorrectly identifies some private IP addresses as public HOT 4
- Security Advisory: NPM ip package still incorrectly identifies some private IP addresses as public HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-ip.