Comments (3)
But the Components::render
wraps the component in additional markup, while render_block_view()
method just includes the PHP file.
What's wrong with echoing it out?
from eightshift-libs.
they both do the same thing but render_block_view
is used inside the blocks only and it doesn't need echo to output the template. This method is only available in blocks and not in the components.
In the components folder and everywhere else we use Components::render
helper this method is built so it needs echo to be able to output the template. My idea is to have both methods behave the same way.
Just and idea, I'm open to new ideas
and
But the Components::render wraps the component in additional markup.
Yes but conditionally not every time.
from eightshift-libs.
We will not implement this.
from eightshift-libs.
Related Issues (20)
- Running use block command in multisite environment executes the command for the main theme HOT 1
- Running boilerplate commands doesn't recognize the context HOT 4
- Text domain slug escaped when using admin menu creation command HOT 1
- Update PHP-DI lib HOT 1
- Memoize calls to manifest HOT 2
- Using wp boilerplate create post-type can produce a syntax error HOT 1
- Fix failing tests HOT 1
- Admin enqueue scripts action is missing hook suffix parameter HOT 1
- Add GH commit helper HOT 1
- Add GH commit helper
- Add filter to exclude some image formats from WebP conversion HOT 2
- cli db import is not working HOT 2
- [FEATURE] - Rename Enqueue Theme to Enqueue Front HOT 2
- [FEATURE] - Create a CLI command to update project version HOT 1
- [BUG] - Error when running init theme command HOT 3
- Replace hardcoded project version with theme version HOT 2
- [FEATURE] - Move the header/footer menu to Appearance submenu
- Remove CliHelpers as trait
- [IMPROVEMENT] - Cli.php auto discover files
- [Improvement] - AllowDynamicProperties improvement
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eightshift-libs.