Comments (3)
Hi @marijang ,
Possibly stupid question, have you echoed it? echo do_shortcode( '[mc4wp_form id="'.$id.'"]' )
.
There's no reason I know of that would prevent shortcodes from working but then again this was never considered / tested since we don't use shortcodes. You can maybe try it on a component that's not echoed using wp_kses_post()
but other than that I have no useful suggestions.
If you find the reason why shortcodes don't work and a fix , a PR would be most welcome.
from eightshift-libs.
i find why
I' m using mailchimp shortcode....
like:
echo wp_kses_post(Components::render( 'mailchimp', [ ....
change to..
echo Components::render( 'mailchimp', [
it works.
There is js code inside shortcode....
Thanks
from eightshift-libs.
Awesome! Even tho it's unsafe to have unfiltered components, it can't really be helped if this requires some 3rd party JS that Mailchimp's shortcode outputs (you'd have to allow the script
tag either way for it to work).
Generally it would be a good idea / practice to write your own wp_kses()
that allows only the tags added by the Mailchmp shortcode and nothing.
https://developer.wordpress.org/reference/functions/wp_kses/
Closing issue, resolved.
from eightshift-libs.
Related Issues (20)
- Running use block command in multisite environment executes the command for the main theme HOT 1
- Running boilerplate commands doesn't recognize the context HOT 4
- Text domain slug escaped when using admin menu creation command HOT 1
- Update PHP-DI lib HOT 1
- Memoize calls to manifest HOT 2
- Using wp boilerplate create post-type can produce a syntax error HOT 1
- Fix failing tests HOT 1
- Admin enqueue scripts action is missing hook suffix parameter HOT 1
- Add GH commit helper HOT 1
- Add GH commit helper
- Add filter to exclude some image formats from WebP conversion HOT 2
- cli db import is not working HOT 2
- [FEATURE] - Rename Enqueue Theme to Enqueue Front HOT 2
- [FEATURE] - Create a CLI command to update project version HOT 1
- [BUG] - Error when running init theme command HOT 3
- Replace hardcoded project version with theme version HOT 2
- [FEATURE] - Move the header/footer menu to Appearance submenu
- Remove CliHelpers as trait
- [IMPROVEMENT] - Cli.php auto discover files
- [Improvement] - AllowDynamicProperties improvement
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eightshift-libs.