Comments (3)
How it actually works:
SANKORE_TRADE_OFFER_SCIENCE & GOLD - city that sends a TR to Sankore gains 1g1s
SANKORE_TRADE_GAIN_SCIENCE - city with Sankore gains 2 science from international TRs
SANKORE_TRADE_DOMESTIC_SCIENCE & FAITH - city that sends a TR to Sankore gains 2s1f
FROM_OTHERS effect (GAIN_SCIENCE) always work with international TRs. TO_OTHERS can be used also for domestic ones.
from civ6-real-fixes.
What is the expected behavior?
- TRs from other Civs provide extra science and gold. ➡️ this is ok, but one small detail that yields go to the sender, but this detail is covered in the Wonder actual description Other Civilizations' Trade Routes to this city provide +1 Science and +1 Gold for them. Probably also partially +2 Science for every Trade Route to this city.
- Domestic TRs yield bonus science and faith. This combined with the description that says +2 Science for every Trade Route to this city and Domestic Trade Routes give an additional +1 Faith to this city leads to the conclusion that the city where the University is built is supposed to be the one receiving those yields.
In other words, international TRs give 1g1s to sender and 2s to Sankore and domestic TRs provide 2s1f only to the wrong city. This is also how modifiers are constructed - OFFER & GAIN for international TRs and DOMESTIC for domestic ones.
Now, there is a problem with FROM_OTHERS effect - it ignored domestic parameter. It means it is not possible to implement the situation where Sankore city gains the yields. Maybe Firaxis found it out and eventually changed the modifier type from FROM_OTHERS to TO_OTHERS. Because if there were no bug then Sankore city would be getting yields as expected and as the description says.
Solution. Since the correct implementation is not possible then the only thing left is to update the description.
from civ6-real-fixes.
Tried to use effect EFFECT_ADJUST_TRADE_ROUTE_YIELD_CHANGE that has AffectDestination and AffectOrigin params. Not working.
[1007903.645] [Turn: 73] Applying effect from <486:SANKORE_TRADE_DOMESTIC_SCIENCE> to <District: 589832, Owner: 0, SubType: 1, SubValue: 173534414, City: 65536>.
[1007903.645] [Turn: 73] Warning: Object <District: 589832, Owner: 0, SubType: 1, SubValue: 173534414, City: 65536> does not support interface <{80A83C2A-9B7F-4AC8-A7AA-80E1E357352A}>.
[1007903.645] [Turn: 73] Failed to apply effect from <486:SANKORE_TRADE_DOMESTIC_SCIENCE> to <District: 589832, Owner: 0, SubType: 1, SubValue: 173534414, City: 65536>.
from civ6-real-fixes.
Related Issues (20)
- Mvemba a Nzinga's LA doesn't benefit from a religion more than any other civ would HOT 2
- Pillaging Dam does NOT yield health
- Wrong artifact era on the popup
- AGENDA_NATURALIST is missing
- (#308) Opponent's Secret Society is always known HOT 1
- Guru is assigned CLASS_MISSIONARY HOT 3
- Is CLASS_ALL_COMBAT_UNITS actually working?
- EFFECT_ADJUST_ALL_UNITS_PURCHASE_COST args check
- MINOR_CIV_RELIGIOUS_YIELD_FOR_CONSULATE is missing CityStatesOnly arg
- Mountain-like features on Mountains don't give science adjacency bonus
- Missing names of abilities with descriptions HOT 2
- Great Musicians from Babylon Pack DLC have 3 charges instead of 2. HOT 2
- CivFanatics issue list 2022 HOT 1
- CivFanatics issue list 2021
- Oracle, Divine Spark, and Theater Squares HOT 2
- Digger resource requirements? HOT 3
- Barbarian Clans Bug
- Victoria Age of Steam description HOT 1
- Cybernetics tooltip missing Lumber Mill info
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from civ6-real-fixes.