Giter Site home page Giter Site logo

Comments (5)

goller avatar goller commented on July 18, 2024

Hi @smolse, we could use an a init for sure. However, is the issue to track in telegraf: influxdata/telegraf#2526

from influxdata-docker.

jsternberg avatar jsternberg commented on July 18, 2024

I also believe this should be something handled by telegraf instead. Telegraf should be starting processes in its own process group and then killing the process group instead of the parent.

While an init system would fix this, I think it acts as a band-aid.

from influxdata-docker.

danielnelson avatar danielnelson commented on July 18, 2024

I left myself a note on the Telegraf exec kill issue to investigate if we ought to signal the process group or just the parent. This is unrelated to the question of init system and won't fully deal with orphans.

IMO It's not a processes job to reap orphans unless it is meant to be pid 1, but if it's not much code we can add it anyway to make things works better in docker. I opened a case for this as well.

from influxdata-docker.

danielnelson avatar danielnelson commented on July 18, 2024

In docker 1.13.0 they have added an --init option that will reap children, so I suggest using this. Telegraf will of course also improve the method it uses to kill subprocesses.

from influxdata-docker.

jsternberg avatar jsternberg commented on July 18, 2024

I think some alternatives have been pointed out and since using an init system like systemd in Docker is not recommended, I'm going to close this.

from influxdata-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.