Telegraf docker entrypoint script change needed to support deployment from compose script

[wz2b]

Telegraf docker entrypoint script change needed to support deployment from compose script

[powersj]

Unfortunately, if you are root, that id will get the groups associated with root, not telegraf. I think it needs to be changed to:

hmm doing so would break what was fixed in #724 where the user does the following:

--user root:$(stat -c '%g' /var/run/docker.sock)

[wz2b]

Does it? Hmm. Setpriv doesn't just add to the effective groups?

It's weird to me to say --user anybody and the entrypoint.sh believes you, but if you say --user root it hijacks the effective user (to make it "telegraf"), but not necessarily the effective group. The thing is, the 'docker' group is usually empty, and 'root' isn't in it, so to fix it they're trying to force the group to match whatever the docker socket's group is.

I think that's the wrong thing to do:

• You should run telegraf with least privilege, and for docker it doesn't need to be root
• You might want to extend this to do other things that require a different group access. The way this guy did it, you can only have one.

I'm thinking the whole thing needs to be reimagined.