isExpanded always returns FALSE

[innovian]

isExpanded always returns FALSE

[CyberMew]

To reproduce, remove the unnecessary UI labels/imageviews from your row.

Remove the codes accordingly referencing those UI controls.

Use this code instead:

-(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath isExpanded:(BOOL)isExpanded
{
static NSString *CellIdentifier = @"Content1";
UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];

if (!isExpanded) //prepare the cell as if it was collapsed! (without any animation!)
{
    cell.textLabel.text = @"!expanded";
}
else ///prepare the cell as if it was expanded! (without any animation!)
{
    cell.textLabel.text = @"expanded";
}
return cell;

}

[xerxes235]

In this method:
-(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath isExpanded:(BOOL)isExpanded
isExpanded is supposed to be false because at app start up all the cells are initially collapsed. You should use these two delegates for setting up your cells in expand/collapse states:
-(void)tableView:(UITableView *)tableView expandCell:(UITableViewCell *)cell withIndexPath:(NSIndexPath *)indexPath
-(void)tableView:(UITableView *)tableView collapseCell:(UITableViewCell *)cell withIndexPath:(NSIndexPath *)indexPath

checkout the project's readme.

[CyberMew]

Hi, can you be more specific, because I took your project and it isn't working correctly. Could you please double confirm on your side using the instructions I have provided to reproduce the problem? I believe we are talking about 2 different things here. I am referring to the boolean inside cellForIndexPath being always false, i.e. the parameter is useless. I do not wish to touch expandCell/collapseCell because cellForIndexPath is sufficient for me needs (if the boolean parameter gets updated correctly)

[xerxes235]

You have misunderstood the usage of cellForRowAtIndexPath. This method is only called when the tableview tends to load a new cell or when you scroll. You get isExpanded = TRUE when you e.g. scroll down to an expanded cell. YOU MUST USE expandCell & collapseCell methods for setting your cell's state change animation. And also prepare your cell in cellForRowAtIndexPath according to isExpanded state.
cellForRowAtIndexPath is not called when you expand a cell. So don't expect it's isExapnded parameter to be set!!!

Please read the Apple documents carefully. This is about the basics of UITableView. And I assure you the project is already double checked from my side.

[CyberMew]

Hi, I understand that the cellForRowAtIndexPath is not called when you expand a cell.

You are misunderstanding what I am trying to say. Please do me a huge favor - add this to your cellForRowAtIndexPath function and let me know if it appears or not. Of course, do scroll the table to make sure it gets refreshed while in expanded state.
if(isExpanded)
NSLog(@"this line will not appear");

[xerxes235]

1. In the example project add these lines immediately after
   UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];

if(isExpanded)
    NSLog(@"this line will not appear");

2. Run the project.
3. Scroll to bottom.
4. Expand the bottommost cell.
5. Scroll to top.
6. Scroll to bottom again.

[CyberMew]

The log showed up for you? That is weird because it didn't for me. It didn't even enter the breakpoint.

[xerxes235]

zip your project and send it to my email: [email protected]

[eugenesv]

I wrote about this issue several days ago but you closed this topic.
This issue takes place in your example project, where method cellForRowAtIndexPath ALWAYS returns FALSE (NO), even if I will expand the cell.
You can make two breakpoints in cellForRow and you will see the issue.

[CyberMew]

Uploaded to your email, please check.

[CyberMew]

Were you able to download it?

[xerxes235]

Yes, I will let you know.

[xerxes235]

A pull request from gavyaggarwal was causing this problem when expandOnlyOnceCell was FALSE; you were right. I have pushed a new commit with the bug fixed. Thanks for your report.

[CyberMew]

Fix confirmed. Adding expandedIndexPaths = [NSMutableArray new]; to init fixes the problems. I skipped out on integrating this to my project because of the time taken. I hope this is a good lesson for not ignoring user reports and actually test them out. This will not go well with customers in the real world, though you actually get paid for it there and not here. Good job, I appreciate the followup. Will use it in the future :)

[xerxes235]

As I said the problem was due to a pull request from gary something. I didnt have enough time to scrutinize every pull request; and I was confident because my commits were working without this bug. However thanks for your report and I will try to spend more time on merging people's pull requests.

Sent from my iPhone

On Sep 15, 2014, at 7:42 AM, CyberMew [email protected] wrote:

Fix confirmed. Adding expandedIndexPaths = [NSMutableArray new]; to init fixes the problems. I skipped out on integrating this to my project because of the time taken. I hope this is a good lesson for not ignoring user reports and actually test them out. This will not go well with customers in the real world, though you actually get paid for it there and not here. Good job, I appreciate the followup. Will use it in the future :)

—
Reply to this email directly or view it on GitHub.