Giter Site home page Giter Site logo

Comments (7)

kuhnroyal avatar kuhnroyal commented on May 17, 2024 1

Yes, the correct way of saying would have been I would have assumed the second way works because it is the one that is promoted in the docs. 🙂

The tests run for a couple minutes so running them twice is twice the time.

from sonar-flutter.

stephanecodes avatar stephanecodes commented on May 17, 2024 1

I created a PR #22 to fix this issue.

If you want to test it, here is the fixed jar :
sonar-flutter-plugin-0.2-1-fix13.zip

from sonar-flutter.

zippy1978 avatar zippy1978 commented on May 17, 2024 1

Hi,
@kuhnroyal PR's are merged and available in release 0.3.0.
I'm closing the issue.

from sonar-flutter.

stephanecodes avatar stephanecodes commented on May 17, 2024

Just switched to 1.19.0-0.0.pre branch and made a quick test.

$ flutter test --machine --coverage >tests.output
$ sonar-scanner

throws an Exception

ERROR: Error during SonarScanner execution
java.lang.NullPointerException
	at fr.insideapp.sonarqube.flutter.tests.FlutterTestReportParser.parse(FlutterTestReportParser.java:58)
	at fr.insideapp.sonarqube.flutter.tests.FlutterTestReportParser.parse(FlutterTestReportParser.java:42)
	at fr.insideapp.sonarqube.flutter.tests.FlutterTestSensor.execute(FlutterTestSensor.java:57)

BUT

$ flutter test --machine > tests.output
$ flutter test --coverage
$ sonar-scanner

works as intended (assuming you're not using SonarQube 8.1+)

So you can use the second solution 😉

from sonar-flutter.

kuhnroyal avatar kuhnroyal commented on May 17, 2024

Thanks for the test, I know the second way works but the goal would be to have the same outcome in one run and reduce build times by several minutes :)

from sonar-flutter.

stephanecodes avatar stephanecodes commented on May 17, 2024

I know the second way works

You said you have not used sonar-flutter yet, that's why I made the tests 🤔

btw, I'm not sure using both options will reduce the total time. I don't see any difference but maybe my project is not as large as yours.

from sonar-flutter.

kuhnroyal avatar kuhnroyal commented on May 17, 2024

I added #25 which builds up on #22 and further improves test parsing, wrong test counts and duration.

from sonar-flutter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.