Retain Cycles

[instacart]

Retain Cycles

[otymartin]

hey @msanders truetime is still leaking quite abit.
This from memory debugger are all truetime related.
From Xcode 9, Swift 4, iOS 10 target.

[msanders]

@otymartin: Thanks for reporting. Was having trouble reproducing but seeing a similar issue now when testing against recurrent timeouts / bad network conditions. Is this related to the scenario you were seeing this in?

[msanders]

@otymartin: This should be fixed now on master and will be included in 4.1.4. Let me know if you run into anything else!

[otymartin]

@msanders
Excuse the late response. Dont know how to answer your question.
I reference TrueTime like this in all my scenarious where I may need to make a network call depended on server time eg. performing transactions. And right before using it, as a safety check I always use guard statement to check if now() exists or fetchInNeed() if now() is nil.

Ill check the new master and report back with any other memory issues.

 fileprivate var now: Date? {
        return TrueTimeClient.sharedInstance.referenceTime?.now()
    }
...
guard let now = self.now else {
            TrueTimeClient.sharedInstance.fetchIfNeeded()
            return
        }

[miketsprague]

This is a bit strange. I'm seeing the same behavior in my app, specifically running this causes 10 leaks according to xcode:

        for i in (0..<10) {
            TrueTimeClient.sharedInstance.fetchIfNeeded()
        }

But I'm unable to reproduce the memory leak in the example project. Could there be a retain cycle in NTPConnection.swift's close? This is calling lockQueue.async(execute: work), where work has a strong reference to self. Does the lockQueue have a strong reference to the work closure (and we have a strong reference to lockQueue)?

Specifying [self weak] in the capture list for that closure "fixed" the issue in my project, but I'm unsure as to why I'm unable to reproduce it in the example project.

Additional reference, I'm using commit 8aadebabe2590d6ab295c390df5bbc109b346348 via cocoapods in my project.

[sangios]

I faced the issue as @msanders reported

[sangios]

The issue still happens.

[Bruce9487]

Have any idea to fix memory leak?

[santanaNogueira]

Did anyone find a solution to this issue? Thanks in advance!