Comments (4)
@manojpandey, could you verify if the exit RabbitMQ spans have proper kind?
from python-sensor.
Because rabbitmq is a dual type span (entry & exit) based on the sort
key it's registered in both ENTRY_SPANS
and EXIT_SPANS
.
So the default exit kind for all spans is 1 (entry):
Line 245 in f800501
Then through the if
statement the exit type condition gets hit (because rabbitmq is a member of ENTRY_SPANS
):
Lines 250 to 252 in f800501
Then we set it back to exit
type if the sort
key matches:
Lines 257 to 258 in f800501
The path of the logic is solid although it's not that evident and could possibly be reorganised to be easier to understand. rabbitmq
is special case because of the kind duality.
It looks like the tests are not validating the kind type so ideally that should be added to the test runs:
https://github.com/instana/python-sensor/blob/master/tests/clients/test_asynqp.py
from python-sensor.
Hey @pglombardo, great to see you again! I see the point, however the problem is that rabbitmq
is listed both in ENTRY_SPANS
and EXIT_SPANS
, and while processing it we'll hit the branch that uses _populate_entry_span_data()
and keeps the self.k
unchanged, so by the time the if "rabbitmq" in self.data and self.data["rabbitmq"]["sort"] == "consume"
is executed, self.k
will be still set to 1
.
from python-sensor.
Vacation has obviously made me weak. I see the bug now. :-)
from python-sensor.
Related Issues (20)
- Python 2.6.6: pkg_resources HOT 1
- Django: Instrumentation can get activated even when django not in use
- aiohttp middleware returns None if handler raises HOT 7
- Automatic memcached instrumentation HOT 1
- Syntax warning and deprecation warning in Python 3.8
- Infinite Recursion when making request HOT 3
- ModuleNotFoundError instrumentation.google on v1.26.0 HOT 1
- Typo in Pika instrumentation
- Sqlalchemy will drop support for Python 2 after v.1.4 HOT 2
- Pub/Sub emulator on v.2.3.0 has issues with SSL handshake
- urllib3 will drop support for Python 2.7 & 3.5 in v.2.0 HOT 1
- pip & Python 2 support HOT 1
- Importing ABC directly from collections has been removed in Python 3.10 in favor of collections.abc HOT 1
- threading.Thread.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10 HOT 1
- Not passing command line arguments to the script HOT 2
- AttributeError when extracting tags from pika BlockingChannel
- [Bug]: Instana interferes with exception raised when connecting to database HOT 3
- [Bug]: Instana AutoTrace causes patroni process to hang HOT 16
- Is Python 3.10 supported? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-sensor.