Giter Site home page Giter Site logo

Link to external pages about instant.page HOT 7 CLOSED

batbyR avatar batbyR commented on May 9, 2024 7
Link to external pages

from instant.page.

Comments (7)

batbyR avatar batbyR commented on May 9, 2024 2

Hi @jerodev,

I see your point.

Can we imagine manually whitelist some external links as we do for query strings?

image

from instant.page.

dieulot avatar dieulot commented on May 9, 2024 2

I’m open to it. quicklink’s readme states that cross-origin requests might bring CORB and CORS issues but in my experience they just work. This might be about quicklink’s fallback to Ajax.

I’ve asked quicklink’s Addy Osmani about it on Twitter. If I hear back positively (or don’t hear back) support for external links will be implemented, probably enabled with an attribute such as data-instant-allow-external-links on the <body>.

from instant.page.

aghorler avatar aghorler commented on May 9, 2024 1

This would be especially useful for websites broken down into sub-domains (eg. links to signup.example.com instead of example.com/signup).

from instant.page.

dieulot avatar dieulot commented on May 9, 2024 1

Okay, this is in. v1.2.0 will let you allow external links with an data-instant-allow-external-links attribute on the <body> or with a data-instant attribute on the link.

from instant.page.

jerodev avatar jerodev commented on May 9, 2024

I suppose this is because the project is meant to speed up your own website and not external websites.

However, I do see why this might be useful in some cases.
It would be great if this would be configurable, but then again you would need a config and it would no longer be possible to have this functionality by just including a script tag.

from instant.page.

bashbaugh avatar bashbaugh commented on May 9, 2024

Also websites might lose visitors when an external website takes too long to load.

from instant.page.

batbyR avatar batbyR commented on May 9, 2024

Great @dieulot ! 👍

I have updated my pull request according to your implementation.

from instant.page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.