Giter Site home page Giter Site logo

Comments (5)

russellb avatar russellb commented on September 15, 2024 1

@cdoern I just changed the title and description of this to reflect what I think needs to be done. I think most of the code will "just work" since the icli workflow is the same. The one piece we're missing is the access control side in the gobot configuration file. We allow requiring a label to be set on PRs, but now we need to be able to check for multiple labels.

from instructlab-bot.

russellb avatar russellb commented on September 15, 2024

some info starting from here: instructlab/instructlab#702

from instructlab-bot.

russellb avatar russellb commented on September 15, 2024

Updated this to blocking priority -- before taxonomy is opened up, we need to configure the bot to require triage OR knowledge labels to be set. See access control docs here - https://github.com/instruct-lab/enhancements/blob/main/docs/github-taxonomy-automation.md

The quickest change is to turn the field in the config from a single item to a list, and in the code, treat the list as a set of OR conditions

from instructlab-bot.

russellb avatar russellb commented on September 15, 2024

If you want to get super fancy, you could allow comma separated labels within each list item where you treat all of those as AND.

That way we can configure any combination of OR + AND logic needed

from instructlab-bot.

russellb avatar russellb commented on September 15, 2024

Implemented in #193

from instructlab-bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.