Giter Site home page Giter Site logo

Comments (7)

uartie avatar uartie commented on July 18, 2024

@XinfengZhang can you specify the specific test cases that fail?

from libva-utils.

uartie avatar uartie commented on July 18, 2024

I see several of them fail due to iHD driver not returning any surface attributes for min/max width/height (e.g. VAProfileVC1Advanced:VAEntrypointVLD).

from libva-utils.

uartie avatar uartie commented on July 18, 2024

@XinfengZhang In iHD driver source, min/max width/height attributes are only returned for VAEntrypointVideoProc and all those test cases pass. The other tests fail because the driver does not return min/max attributes.

I agree, though, that the test should check min resolution too... but this is not the cause for the failures since driver doesn't even return those attribs. Please fix the driver to provide those attribs.

from libva-utils.

uartie avatar uartie commented on July 18, 2024

On the flip-side, I suppose if driver does not specify VASurfaceAttribMaxWidth/Height or VASurfaceAttribMinWidth/Height then applications/tests should assume "any" max is allowed and 0 (or 1) is minimum? @xhaihao what's your recommendation?

from libva-utils.

xhaihao avatar xhaihao commented on July 18, 2024

I prefer '1' as the minimum if the driver doesn't set VASurfaceAttribMinWidth/Height. I agree 'any' max should be allowed if the driver doesn't specify VASurfaceAttribMaxWidth/Height.

from libva-utils.

XinfengZhang avatar XinfengZhang commented on July 18, 2024

@uartie, there are several PR in the https://github.com/intel/media-driver/pulls, Max/Min solution is added for both Decode & Encode, after them, there are still failed. I checked the failed case , and find , if driver report min resolution is 32x32, but our test still expect success with resolution 16x16.

from libva-utils.

uartie avatar uartie commented on July 18, 2024

@XinfengZhang I will submit a patch to fix that here.

from libva-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.