Giter Site home page Giter Site logo

Comments (6)

itaicaspi-intel avatar itaicaspi-intel commented on May 19, 2024

Thanks Zach, I think that this is a good suggestion.
Maybe something along the lines of Gym's register environment?
To allow using Coach within other scripts, it would probably also be good to have a better python interface to Coach, such as the one you cited from rllab.

from coach.

jtoy avatar jtoy commented on May 19, 2024

agree, would love this. I wanted to try using this with https://github.com/jtoy/sensenet as its openai compatible, but there were too many files to modify.

from coach.

zach-nervana avatar zach-nervana commented on May 19, 2024

I added a new method for specifying which environment to use in the case that the environment follows the interface provided by openai gym. In a preset, you can now specify the environment via: env.level = 'package.module:ClassName'. This means that new environments and be integrated more easily. The only place where coach needs modified to work with new environments now is presets.py. This change was completed in #41.

I will leave this issue open because it would still be nice to configure coach without modifying presets.py. Also, this fix is only helpful in the case that your environment is a gym environment.

from coach.

jtoy avatar jtoy commented on May 19, 2024

@zach-nervana Great, I'll test it out and let you know.

from coach.

saddy001 avatar saddy001 commented on May 19, 2024

@zach-nervana could you update the docs (https://nervanasystems.github.io/coach/contributing/add_env/index.html) to reflect your change?

Thanks,

from coach.

itaicaspi-intel avatar itaicaspi-intel commented on May 19, 2024

thanks @saddy001, it is now updated in https://nervanasystems.github.io/coach/contributing/add_env/index.html as you suggested.
the environment integration process was simplified as well, and we also have a step by step tutorial notebook to accompany the documentation (https://github.com/NervanaSystems/coach/blob/master/tutorials/2.%20Adding%20an%20Environment.ipynb)

from coach.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.