Giter Site home page Giter Site logo

Comments (5)

amueller avatar amueller commented on May 30, 2024 2

And again, it's also an issue of how you display the results. I'm much more likely to believe a speedup of 20x from .1s to 0.005s than from 1h to 3m. If something is instantaneous, we don't really try to optimize much more usually.

from scikit-learn_bench.

amueller avatar amueller commented on May 30, 2024

It would also be great to have the absolute times, not only the relative times. Some of these algorithms take .5s. In that case our input validation overhead probably is possibly dominating the work.

from scikit-learn_bench.

bibikar avatar bibikar commented on May 30, 2024

Hi @amueller,

We can definitely try both tall and wide data and report absolute timing. As for input validation, we disable it entirely here. That basically calls sklearn.set_config(assume_finite=True).

Currently, sparse inputs will always cause our patches to fall back to scikit-learn or convert the sparse matrix to a dense one.

from scikit-learn_bench.

amueller avatar amueller commented on May 30, 2024

@bibikar enabling assume_finite is definitely the right way to go. Still, I don't expect anything that takes .5s to be optimized in sklearn. Can you run something that takes like 10s or 1m?

from scikit-learn_bench.

napetrov avatar napetrov commented on May 30, 2024

In last several years datasets sizes get more variety and we are working on including more datasets with introduction of GPU support

from scikit-learn_bench.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.