Giter Site home page Giter Site logo

Comments (12)

adierkens avatar adierkens commented on August 31, 2024 1

Should be released in 2.17.3

from design-systems-cli.

adierkens avatar adierkens commented on August 31, 2024 1

@danilomartinelli #654

from design-systems-cli.

adierkens avatar adierkens commented on August 31, 2024 1

Can you open a separate issue?
I'm going to close this one out since this is no longer a problem -- but feel free to open new ones as you hit them (and PRs if you can 😄)

from design-systems-cli.

gwevans avatar gwevans commented on August 31, 2024

@adierkens Is there a workaround to get storybook up and running?

from design-systems-cli.

shriuken avatar shriuken commented on August 31, 2024

@gwevans I did this earlier this week, from what I remember I needed to manually install storybook and then update the .storybook/main.js to grep correctly for component stories, and deleted all root-level-generated files that storybook created.

Specifically...

  1. From the root of your design-cli powered repo, install storybook npx sb init
  2. Delete auto-generated storybook files that get created at the root of your project except for the .storybook folder/files
  3. Modify .storybook/main.js to look like:
module.exports = {
  "stories": [
    "../components/**/*.stories.mdx",
    "../components/**/*.stories.@(js|jsx|ts|tsx)"
  ],
  "addons": [
    "@storybook/addon-links",
    "@storybook/addon-essentials"
  ]
}

from design-systems-cli.

gwevans avatar gwevans commented on August 31, 2024

@gwevans I did this earlier this week, from what I remember I needed to manually install storybook and then update the .storybook/main.js to grep correctly for component stories, and deleted all root-level-generated files that storybook created.

Thanks @shriuken, that worked for me.

from design-systems-cli.

danilomartinelli avatar danilomartinelli commented on August 31, 2024

Hello, this is not enough, it is necessary to keep the storybook settings made by the CLI. CSS is not persisted for example.

from design-systems-cli.

danilomartinelli avatar danilomartinelli commented on August 31, 2024

I created a new project after that PR but not work yet. (I ran npm init @design-system today)

from design-systems-cli.

yucho avatar yucho commented on August 31, 2024

@shriuken Can we at least get the patch release for #651 (a.k.a. #652)? The current latest version is broken but this will fix our problem

from design-systems-cli.

danilomartinelli avatar danilomartinelli commented on August 31, 2024

@adierkens I updated today using ds update to 2.17.3 but i got the following error when i ran yarn run dev (ds dev):
Captura de Tela 2021-05-16 às 12 54 31

from design-systems-cli.

danilomartinelli avatar danilomartinelli commented on August 31, 2024

Ok, I'm looking forwarding for this PR. Important to create a version of the CLI with this fix. Thanks!

from design-systems-cli.

danilomartinelli avatar danilomartinelli commented on August 31, 2024

@adierkens I updated to @design-systems/cli": "2.17.4--canary.654.17576.0 and @design-systems/storybook": "2.17.4--canary.654.17576.0 in Root and now is running smoothly. But styles are not being important.
Captura de Tela 2021-05-17 às 08 54 40
Captura de Tela 2021-05-17 às 08 54 45

from design-systems-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.