Comments (12)
Should be released in 2.17.3
from design-systems-cli.
from design-systems-cli.
Can you open a separate issue?
I'm going to close this one out since this is no longer a problem -- but feel free to open new ones as you hit them (and PRs if you can 😄)
from design-systems-cli.
@adierkens Is there a workaround to get storybook up and running?
from design-systems-cli.
@gwevans I did this earlier this week, from what I remember I needed to manually install storybook and then update the .storybook/main.js
to grep correctly for component stories, and deleted all root-level-generated files that storybook created.
Specifically...
- From the root of your design-cli powered repo, install storybook
npx sb init
- Delete auto-generated storybook files that get created at the root of your project except for the
.storybook
folder/files - Modify
.storybook/main.js
to look like:
module.exports = {
"stories": [
"../components/**/*.stories.mdx",
"../components/**/*.stories.@(js|jsx|ts|tsx)"
],
"addons": [
"@storybook/addon-links",
"@storybook/addon-essentials"
]
}
from design-systems-cli.
@gwevans I did this earlier this week, from what I remember I needed to manually install storybook and then update the
.storybook/main.js
to grep correctly for component stories, and deleted all root-level-generated files that storybook created.
Thanks @shriuken, that worked for me.
from design-systems-cli.
Hello, this is not enough, it is necessary to keep the storybook settings made by the CLI. CSS is not persisted for example.
from design-systems-cli.
I created a new project after that PR but not work yet. (I ran npm init @design-system today)
from design-systems-cli.
@shriuken Can we at least get the patch release for #651 (a.k.a. #652)? The current latest version is broken but this will fix our problem
from design-systems-cli.
@adierkens I updated today using ds update
to 2.17.3 but i got the following error when i ran yarn run dev
(ds dev
):
from design-systems-cli.
Ok, I'm looking forwarding for this PR. Important to create a version of the CLI with this fix. Thanks!
from design-systems-cli.
@adierkens I updated to @design-systems/cli": "2.17.4--canary.654.17576.0
and @design-systems/storybook": "2.17.4--canary.654.17576.0
in Root and now is running smoothly. But styles are not being important.
from design-systems-cli.
Related Issues (20)
- Update Proof plugin to latest version (0.1.1) HOT 10
- Dependency Dashboard
- Auto Formatting Code Using Prettier Action
- yarn start: 'tsc' is not recognized as an internal or external command HOT 21
- Add Contributing Guide HOT 2
- Improve ReadMe HOT 1
- Update Typings HOT 2
- Build Testing HOT 3
- Commit Lint Support HOT 2
- npm failing to install @design-systems HOT 6
- postcss-loader webpack config uses outdated options object
- feature: upgrade to Yarn 2
- Tests do not fail if coverage does not meet thresholds
- Options issue in styled.tsx
- Add support for component size limits
- Is dark mode possible in the docs?
- Not reading the latest version of component template repo
- Accessibility Keyboard Testing Issues
- Test script does not fire the correct exit code during test suite failures HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from design-systems-cli.