Comments (9)
HI @brockallen - We didn't mean to leave off the copyright and we will open up an issue with open source identity team to address it. Meanwhile, I have updated the files even the modified, added ones to include the Licensing from IdentityModel2 repo.
Thanks,
Nimisha
from quickbooks-v3-dotnet-sdk.
Thank you for following up on this.
I think moving forward we want to understand what in IdentityModel was blocking you in the first place. Did you open any issues in our repo asking for enhancements? I would think that's the best approach: 1) let us know what might need changing to support your scenario, and 2) then you should be referencing our library via the nuget package rather than copying the source code.
If that was done originally, then this issue could have been avoided.
from quickbooks-v3-dotnet-sdk.
Hi @brockallen,
Intuit mistakenly published this library without the copyright notice. This was an oversight on our part, and the result of a misunderstanding of the open source licensing process by our team. We fully support the open source community and regret our error.
The issue has been corrected here: 506b872#diff-68341b3e1ed04a5b6a86868254db097d
regards
Jarred Keneally
Director, Intuit Developer Relations
from quickbooks-v3-dotnet-sdk.
Hi @brockallen - I will setup a call with you in a week's time to go over the changes we did for the Intuit's implementation as it was limited to just server side Oauth2 support and having some additional params like realm/company id support. Hopefully you could help us with the questions then and suggest what best we can do to handle those using your binaries instead. Thanks for the guidelines.
from quickbooks-v3-dotnet-sdk.
Yes, I was able to get all my questions answered. However, I am currently on maternity leave for 3 weeks. Once I return back, I will give you an update on the release for the Oauth2 lib using the binaries. Thanks for all the help.
from quickbooks-v3-dotnet-sdk.
Were you able to finally get all your questions/features covered with IdentityModel? If so, then were you able to get the code to reuse IdentityModel as a NuGet, which is preferable to copying the code in?
from quickbooks-v3-dotnet-sdk.
Ok, thanks for the update.
And congratulations!
from quickbooks-v3-dotnet-sdk.
Hi @brockallen,
Just wanted to update this thread too.
We discussed with @leastprivilege here- IdentityModel/IdentityModel#164 (comment)
and with Scott too.
Due to limitation of Dotnet extensions for adding new properties and lack of support for domain specific properties, we will not be making any code changes to the Oauth2PlatformClient as this will break client apps using our SDK.
Also, the “type” of response for different endpoints would be different – instead of Intuit.Ipp.Oauth2PlatformClient unless we explicitly hardcode each and every response property value. Not a goof solution for us to use the binaries then. Again this would be a breaking change.
We will consider the use of binaries once we migrate our SDK to support .Net Core.
Thanks,
Nimisha
from quickbooks-v3-dotnet-sdk.
Fair enough. Thanks for the updates to restore the copyrights and honor the license.
from quickbooks-v3-dotnet-sdk.
Related Issues (20)
- Should SalesItemLineDetail have a UnitPrice property? HOT 3
- Refund Receipts and Credit Memos
- .NET Compatability HOT 1
- Connect
- Connect_tartle.co
- Remove ancillary serilog dependencies
- BinaryFormatter is used in your code HOT 1
- NuGet package no longer lists Newtonsoft.Json as a dependency, but it's still required HOT 2
- Sales Order
- Please remove Serilog dependencies
- IppDotNetSdkForQuickBooksApiV3 all nuget package versions are deprecated? HOT 2
- Please remove serilog dependencies HOT 11
- Can't add a TaxCode, URL SDK is using is incorrect
- serilog dependencies
- Unable to get the Vendor Credit applied to a bill
- Yet another problem due to serilog dependencies HOT 1
- "Invalid URI or Environment" in Blazor WASM app HOT 1
- BadRequest on SalesReceipt Add when using SalesLineItemDetail HOT 4
- When using the attachment API to upload the png file with content type "image/png" it does not upload the file comes back with null Attachable. Works for every other file type.
- Date deserialization broken since 14.6.3.5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickbooks-v3-dotnet-sdk.