Comments (5)
Hi @carlbleick, I applied the changes in the PR directly in my app code along with the code changes in AppDelegate suggested by Shake, it worked as expected. However, I didn’t get round to testing non-Shake notification presses with those changes applied but I believe they should still be handled by notifee because the fallback is just to run the original delegate completionHandler.
My understanding might be a little off but I’d suggest applying the PR changes directly in your own code to see if the merge would resolve your own situation.
from notifee.
I found this PR, applied the changes and this fixes my issue, so closing this in anticipation of that getting merged.
from notifee.
@gezquinndesign Did you replace all push notification press actions with your own custom UNUserNotificationCenterDelegate by Shake's Chat feature? Or are you still managing some push notification presses directly via notifee?
from notifee.
Hi @carlbleick, if and when the PR gets merged, I’m expecting to still use notifee to manage the non-shake notifications. The custom handler intercepts the notification press, checks if it’s from Shake and deals with it accordingly. If it’s not a Shake notification it just calls the usual completionHandler. I hope that makes sense. Any reason you want to know?
from notifee.
@gezquinndesign Thanks for your reply! It makes sense to me. I just dont quite understand how the notifee code knows wether the Shake delegate is reacting to that specific notification or not.
I understood it in a way that notifee would always call the Shake delegate as soon as there is one - not explicitly checking wether that specific notification is actually handled.
Have you tested the behaviour yourself already or are you waiting for the PR merge?
I want to know because I am currently patching the library myself to do almost the same (#925).
from notifee.
Related Issues (20)
- Unable to Schedule Daily Notifications HOT 1
- Android14 : Background Job HOT 2
- Android :: Small Icons shown only on foreground notifications but not background ones HOT 1
- I'm updated my react native version to 0.73.4 and getInitialNotification() and onNotificationOpenedApp() does not work in iOS HOT 5
- IOS: A local notification without sound and vibration HOT 1
- iOS handle consecutive push notifications with long sound HOT 1
- [iOS] Attachment image is not displayed with 'require()' on release mode HOT 1
- [Android] notifee.openAlarmPermissionSettings() on Samsung phone (Android 14) just goes to Settings app HOT 1
- Apple's privacy manifest HOT 6
- Getting TypeError: Cannot read property 'then' of undefined when calling getNotificationSettings (on Android) HOT 2
- How to remove USE_FULL_SCREEN_INTENT? HOT 14
- Android 14: Local push notifications don't disappear until user dismiss or touch them HOT 1
- Object literal may only specify known properties, and 'inAppNotificationSettings' does not exist in type 'IOSNotificationPermissions' HOT 1
- Declaration USE_FULL_SCREEN_INTENT permission HOT 3
- IOS & ANDROID: Not able to get quick actions when app is in background or kill/quit state HOT 2
- [iOS] Timestamp trigger notifications arrive at incorrect time after device timezone change HOT 2
- [iOS] add openNotificationSettings HOT 1
- [Android] description of permissions used HOT 2
- Not able to retrieve data when app is in kill/background mode to navigate to specific screen HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notifee.