Giter Site home page Giter Site logo

Comments (5)

gezquinndesign avatar gezquinndesign commented on July 20, 2024 1

Hi @carlbleick, I applied the changes in the PR directly in my app code along with the code changes in AppDelegate suggested by Shake, it worked as expected. However, I didn’t get round to testing non-Shake notification presses with those changes applied but I believe they should still be handled by notifee because the fallback is just to run the original delegate completionHandler.

My understanding might be a little off but I’d suggest applying the PR changes directly in your own code to see if the merge would resolve your own situation.

from notifee.

gezquinndesign avatar gezquinndesign commented on July 20, 2024

I found this PR, applied the changes and this fixes my issue, so closing this in anticipation of that getting merged.

from notifee.

carlbleick avatar carlbleick commented on July 20, 2024

@gezquinndesign Did you replace all push notification press actions with your own custom UNUserNotificationCenterDelegate by Shake's Chat feature? Or are you still managing some push notification presses directly via notifee?

from notifee.

gezquinndesign avatar gezquinndesign commented on July 20, 2024

Hi @carlbleick, if and when the PR gets merged, I’m expecting to still use notifee to manage the non-shake notifications. The custom handler intercepts the notification press, checks if it’s from Shake and deals with it accordingly. If it’s not a Shake notification it just calls the usual completionHandler. I hope that makes sense. Any reason you want to know?

from notifee.

carlbleick avatar carlbleick commented on July 20, 2024

@gezquinndesign Thanks for your reply! It makes sense to me. I just dont quite understand how the notifee code knows wether the Shake delegate is reacting to that specific notification or not.
I understood it in a way that notifee would always call the Shake delegate as soon as there is one - not explicitly checking wether that specific notification is actually handled.

Have you tested the behaviour yourself already or are you waiting for the PR merge?

I want to know because I am currently patching the library myself to do almost the same (#925).

from notifee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.