[🐛] 🔥Support for inequality filters on multiple fields

[thisisgit]

[🐛] 🔥Support for inequality filters on multiple fields

[thisisgit]

I found where that validateWhere is located:

react-native-firebase/packages/firestore/lib/FirestoreQueryModifiers.js

Lines 237 to 341 in ca07cad

	validateWhere() {
	if (this._filters.length > 0) {
	this._filterCheck(this._filters);
	}
	}
	_filterCheck(filters) {
	for (let i = 0; i < filters.length; i++) {
	const filter = filters[i];
	if (filter.queries) {
	// Recursively check sub-queries for Filters
	this._filterCheck(filter.queries);
	// If it is a Filter query, skip the rest of the loop
	continue;
	}
	// Skip if no inequality
	if (!INEQUALITY[filter.operator]) {
	continue;
	}
	if (filter.operator === OPERATORS['!=']) {
	if (this.hasNotEqual) {
	throw new Error("Invalid query. You cannot use more than one '!=' inequality filter.");
	}
	//needs to set hasNotEqual = true before setting first hasInequality = filter. It is used in a condition check later
	this.hasNotEqual = true;
	}
	// Set the first inequality
	if (!this.hasInequality) {
	this.hasInequality = filter;
	continue;
	}
	// Check the set value is the same as the new one
	if (INEQUALITY[filter.operator] && this.hasInequality) {
	if (this.hasInequality.fieldPath._toPath() !== filter.fieldPath._toPath()) {
	throw new Error(
	`Invalid query. All where filters with an inequality (<, <=, >, != or >=) must be on the same field. But you have inequality filters on '${this.hasInequality.fieldPath._toPath()}' and '${filter.fieldPath._toPath()}'`,
	);
	}
	}
	}
	for (let i = 0; i < filters.length; i++) {
	const filter = filters[i];
	if (filter.operator === OPERATORS['array-contains']) {
	if (this.hasArrayContains) {
	throw new Error('Invalid query. Queries only support a single array-contains filter.');
	}
	this.hasArrayContains = true;
	}
	if (filter.operator === OPERATORS['array-contains-any']) {
	if (this.hasArrayContainsAny) {
	throw new Error(
	"Invalid query. You cannot use more than one 'array-contains-any' filter.",
	);
	}
	if (this.hasNotIn) {
	throw new Error(
	"Invalid query. You cannot use 'array-contains-any' filters with 'not-in' filters.",
	);
	}
	this.hasArrayContainsAny = true;
	}
	if (filter.operator === OPERATORS.in) {
	if (this.hasNotIn) {
	throw new Error("Invalid query. You cannot use 'in' filters with 'not-in' filters.");
	}
	this.hasIn = true;
	}
	if (filter.operator === OPERATORS['not-in']) {
	if (this.hasNotIn) {
	throw new Error("Invalid query. You cannot use more than one 'not-in' filter.");
	}
	if (this.hasNotEqual) {
	throw new Error(
	"Invalid query. You cannot use 'not-in' filters with '!=' inequality filters",
	);
	}
	if (this.hasIn) {
	throw new Error("Invalid query. You cannot use 'not-in' filters with 'in' filters.");
	}
	if (this.hasArrayContainsAny) {
	throw new Error(
	"Invalid query. You cannot use 'not-in' filters with 'array-contains-any' filters.",
	);
	}
	this.hasNotIn = true;
	}
	}
	}

So what it does is to recursively call _filterCheck function, and the first for loop of the function is responsible for checking inequality filter for multiple fields.
I believe that for loop can now be removed since it's now supported.

I wanted to open a PR for this but for some reason, it returns 403 whenever I try to push working branch to remote as described here.