Require local image throws error for Android largeIcon

[invertase]

Require local image throws error for Android largeIcon

[Ehesp]

Hm yeah, the | undefined part is really saying "don't add this key/value pair".

We're checking for property exists, which in this case, it does so it goes into that trap. Maybe we should just convert them to !isUndefined()

[Salakar]

@Eralyne could you try largeIcon: require('./Images/logo.png').uri - I think our docs might need updating

[Eralyne]

There doesn't seem to be an error thrown anymore but I have yet to test if the icon appears.

[whenmoon]

I am still getting the error:

Error: notifee.displayNotification(*) 'notification.android.largeIcon' expected a string value

with the code:

largeIcon: require('../../assets/large-notification-icon.jpg').uri,

[roni-castro]

It also happens if you try using an url. I think the types needs to be updated or fixed, as most properties (largeIcon, title, subtitle, body, data...) have invalid type definition:

This works:

 android: {
      largeIcon: 'https://repository-images.githubusercontent.com/226108661/7d2c3380-1aab-11ea-885e-f3466be45c26'
}

This does not work:

 android: {
      largeIcon: ''
}

This does not work:

 android: {
      largeIcon: undefined
}

Error:

Possible Unhandled Promise Rejection (id: 0):
Error: notifee.displayNotification(*) 'notification.android.largeIcon' expected a string value.
Error: notifee.displayNotification(*) 'notification.android.largeIcon' expected a string value.
    at NotifeeApiModule.displayNotification (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:141175:17)
    at showNotification$ (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:1849:68)
    at tryCatch (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:41180:19)
    at Generator.invoke [as _invoke] (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:41355:24)
    at Generator.prototype.<computed> [as next] (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:41223:23)
    at tryCatch (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:41180:19)
    at invoke (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:41256:22)
    at blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:41266:15
    at tryCallOne (blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:45659:14)
    at blob:file:///2bf99935-1ffc-4fef-bd95-58d94339e3ae:45760:17

[Salakar]

This has been fixed in 0.6.2 - changelog still to do but theres only 1 breaking change, renaming usages of Importance to AndroidImportance. Please give it a try, you only need the require now, without .uri

Thanks