[bug]: Some T2I Adapter settings are not preserved as metadata

[trmusson]

[bug]: Some T2I Adapter settings are not preserved as metadata

[psychedelicious]

The threshold values you are referring to aren't actually part of the generation. They are a pre-processing of the input control image. They are not saved to the metadata and I don't anticipate saving them.

What is saved to the metadata is the reference to the processed control image. This is what is actually used during generation. When I follow your steps, I do get exactly the same image after using recall all.

I think there's something missing from your steps to reproduce. Perhaps a different piece of metadata isn't recorded.

But - even if the metadata is perfectly saved and recalled and used, recreated a previous generation is best-effort only. We cannot guarantee reproducibility for image generation. Why not?

1. Changes to dependencies (e.g. torch, diffusers - things we use, but don't maintain) may mean generating again with the exact same settings yields a different image.
2. A bugfix can drastically alter image outputs.
3. Changes to how settings are handled from version to version may drastically alter image outputs.

[psychedelicious]

With the v4.2.0 release, control adapters have been reworked and the full state of a control layer (including the processor config) is persisted/recalled to/from metadata.